public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/95408] Failure to optimize bitwise and with negated conditional using the same operand to conditional with decremented operand
Date: Sat, 13 May 2023 05:47:28 +0000	[thread overview]
Message-ID: <bug-95408-4-R2kfIPa1aI@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-95408-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95408

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org
   Last reconfirmed|                            |2023-05-13
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
For unsigned x (to simplify things first).
In forwardprop4 we have
  _1 = x_4(D) <= 121211;
  _3 = _1 ? x_4(D) : 0;
  _5 = _3 != 0;

This could be done as:
x_4(D) <= 121211 ? x_4(D) != 0 : 0

Which then would be:
(x_4(D) <= 121211 & x_4(D) != 0) 
((x_4(D) - 1) <= 121210)

So I have a patch which does the second step into the 3rd expression (there is
another bug or 2 about it). the 3rd expression into the final is already done.
It is just the first that needs to happen to written up.

Something like this for the first step.
(for op (tcc_comparison)
/* (c ? a : CST0) op CST1  -->  c ? (a op CST1) : (CST0 op CST1) */
 (simplify
  (op (cond:s @0 @1 CONSTANT_CLASS_P@2) CONSTANT_CLASS_P@3)
  (cond! @0 (op @1 @3) (op @2 @4)))

So mine.

  parent reply	other threads:[~2023-05-13  5:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29  9:40 [Bug tree-optimization/95408] New: " gabravier at gmail dot com
2021-04-26  1:15 ` [Bug tree-optimization/95408] " pinskia at gcc dot gnu.org
2023-05-13  5:47 ` pinskia at gcc dot gnu.org [this message]
2023-08-23  2:36 ` pinskia at gcc dot gnu.org
2023-09-16  6:25 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-95408-4-R2kfIPa1aI@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).