* [Bug gcov-profile/95480] GCOV change breaks AIX build
2020-06-02 14:41 [Bug gcov-profile/95480] New: GCOV change breaks AIX build dje at gcc dot gnu.org
@ 2020-06-02 14:43 ` dje at gcc dot gnu.org
2020-06-02 14:46 ` dje at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: dje at gcc dot gnu.org @ 2020-06-02 14:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95480
David Edelsohn <dje at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Last reconfirmed| |2020-06-02
Status|UNCONFIRMED |NEW
--- Comment #1 from David Edelsohn <dje at gcc dot gnu.org> ---
Likely caused by
commit 871e5ada6d53d5eb495cc9f323983f347487c1b2
Author: Martin Liska <mliska@suse.cz>
Date: Fri Jan 31 13:10:14 2020 +0100
Make TOPN counter dynamically allocated.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug gcov-profile/95480] GCOV change breaks AIX build
2020-06-02 14:41 [Bug gcov-profile/95480] New: GCOV change breaks AIX build dje at gcc dot gnu.org
2020-06-02 14:43 ` [Bug gcov-profile/95480] " dje at gcc dot gnu.org
@ 2020-06-02 14:46 ` dje at gcc dot gnu.org
2020-06-02 14:52 ` dje at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: dje at gcc dot gnu.org @ 2020-06-02 14:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95480
--- Comment #2 from David Edelsohn <dje at gcc dot gnu.org> ---
$ nm -BCpg libgcov-merge-tool.o | grep _8
- U .__atomic_fetch_add_8
- U .__sync_val_compare_and_swap_8
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug gcov-profile/95480] GCOV change breaks AIX build
2020-06-02 14:41 [Bug gcov-profile/95480] New: GCOV change breaks AIX build dje at gcc dot gnu.org
2020-06-02 14:43 ` [Bug gcov-profile/95480] " dje at gcc dot gnu.org
2020-06-02 14:46 ` dje at gcc dot gnu.org
@ 2020-06-02 14:52 ` dje at gcc dot gnu.org
2020-06-02 14:54 ` dje at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: dje at gcc dot gnu.org @ 2020-06-02 14:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95480
--- Comment #3 from David Edelsohn <dje at gcc dot gnu.org> ---
Demangling the function names in the assembly output
gcov_counter_add(long long*, long long, int)
...
bl .__atomic_fetch_add_8
gcov_counter_set_if_null(long long*, gcov_kvp*, int)
...
bl .__sync_val_compare_and_swap_8
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug gcov-profile/95480] GCOV change breaks AIX build
2020-06-02 14:41 [Bug gcov-profile/95480] New: GCOV change breaks AIX build dje at gcc dot gnu.org
` (2 preceding siblings ...)
2020-06-02 14:52 ` dje at gcc dot gnu.org
@ 2020-06-02 14:54 ` dje at gcc dot gnu.org
2020-06-02 14:55 ` marxin at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: dje at gcc dot gnu.org @ 2020-06-02 14:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95480
--- Comment #4 from David Edelsohn <dje at gcc dot gnu.org> ---
The references only occur when compiling without optimization during stage1.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug gcov-profile/95480] GCOV change breaks AIX build
2020-06-02 14:41 [Bug gcov-profile/95480] New: GCOV change breaks AIX build dje at gcc dot gnu.org
` (3 preceding siblings ...)
2020-06-02 14:54 ` dje at gcc dot gnu.org
@ 2020-06-02 14:55 ` marxin at gcc dot gnu.org
2020-06-02 14:55 ` marxin at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-06-02 14:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95480
--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
I have a patch candidate and I know the root cause of the patch.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug gcov-profile/95480] GCOV change breaks AIX build
2020-06-02 14:41 [Bug gcov-profile/95480] New: GCOV change breaks AIX build dje at gcc dot gnu.org
` (4 preceding siblings ...)
2020-06-02 14:55 ` marxin at gcc dot gnu.org
@ 2020-06-02 14:55 ` marxin at gcc dot gnu.org
2020-06-02 14:58 ` marxin at gcc dot gnu.org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-06-02 14:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95480
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |marxin at gcc dot gnu.org
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug gcov-profile/95480] GCOV change breaks AIX build
2020-06-02 14:41 [Bug gcov-profile/95480] New: GCOV change breaks AIX build dje at gcc dot gnu.org
` (5 preceding siblings ...)
2020-06-02 14:55 ` marxin at gcc dot gnu.org
@ 2020-06-02 14:58 ` marxin at gcc dot gnu.org
2020-06-02 15:10 ` dje at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-06-02 14:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95480
--- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
Created attachment 48661
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48661&action=edit
Patch candidate
@David: Can you please test the patch?
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug gcov-profile/95480] GCOV change breaks AIX build
2020-06-02 14:41 [Bug gcov-profile/95480] New: GCOV change breaks AIX build dje at gcc dot gnu.org
` (6 preceding siblings ...)
2020-06-02 14:58 ` marxin at gcc dot gnu.org
@ 2020-06-02 15:10 ` dje at gcc dot gnu.org
2020-06-03 6:13 ` cvs-commit at gcc dot gnu.org
2020-06-03 6:13 ` marxin at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: dje at gcc dot gnu.org @ 2020-06-02 15:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95480
--- Comment #7 from David Edelsohn <dje at gcc dot gnu.org> ---
AIX build is happier with the patch
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug gcov-profile/95480] GCOV change breaks AIX build
2020-06-02 14:41 [Bug gcov-profile/95480] New: GCOV change breaks AIX build dje at gcc dot gnu.org
` (7 preceding siblings ...)
2020-06-02 15:10 ` dje at gcc dot gnu.org
@ 2020-06-03 6:13 ` cvs-commit at gcc dot gnu.org
2020-06-03 6:13 ` marxin at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-06-03 6:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95480
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:
https://gcc.gnu.org/g:eb3480fc0fe68c0062a5548e922d530c78121cb5
commit r11-841-geb3480fc0fe68c0062a5548e922d530c78121cb5
Author: Martin Liska <mliska@suse.cz>
Date: Tue Jun 2 16:57:35 2020 +0200
gcov: Fix build on AIX
We must guard used atomic builtins with GCOV_SUPPORTS_ATOMIC.
The patch is tested on AIX and I'm going to push it.
libgcc/ChangeLog:
PR gcov-profile/95480
* libgcov-profiler.c (GCOV_SUPPORTS_ATOMIC): Move to...
* libgcov.h (GCOV_SUPPORTS_ATOMIC): ...here.
(gcov_counter_add): Use GCOV_SUPPORTS_ATOMIC guard.
(gcov_counter_set_if_null): Likewise.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug gcov-profile/95480] GCOV change breaks AIX build
2020-06-02 14:41 [Bug gcov-profile/95480] New: GCOV change breaks AIX build dje at gcc dot gnu.org
` (8 preceding siblings ...)
2020-06-03 6:13 ` cvs-commit at gcc dot gnu.org
@ 2020-06-03 6:13 ` marxin at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-06-03 6:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95480
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #9 from Martin Liška <marxin at gcc dot gnu.org> ---
Should be fixed now.
^ permalink raw reply [flat|nested] 11+ messages in thread