public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "dcb314 at hotmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/95512] gcc/fortran/trans-decl.c:1066: array sanity check after use Date: Sat, 06 Jun 2020 20:42:13 +0000 [thread overview] Message-ID: <bug-95512-4-6s6Rr6Cm9Y@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-95512-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95512 --- Comment #4 from David Binderman <dcb314 at hotmail dot com> --- (In reply to anlauf from comment #3) > I didn't write the code, but for more context: Thanks for the extra context. > Maybe it is bad style, but I still consider it a false positive. If you go back and check what cppcheck is saying, it is merely mentioning what it thinks is bad style. > cppcheck's view is probably too narrow to understand the range of dim. Agreed. AFAIK cppcheck merely searches and reports on source code patterns like if (arrayName[ X] && X < someExpression) Whether you want to keep the code in bad style is up to you. I did originally suggest some code that looked IMHO to be better style.
next prev parent reply other threads:[~2020-06-06 20:42 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-03 19:46 [Bug fortran/95512] New: " dcb314 at hotmail dot com 2020-06-05 21:24 ` [Bug fortran/95512] " anlauf at gcc dot gnu.org 2020-06-06 6:26 ` dcb314 at hotmail dot com 2020-06-06 19:59 ` anlauf at gcc dot gnu.org 2020-06-06 20:42 ` dcb314 at hotmail dot com [this message] 2020-06-14 12:54 ` tkoenig at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-95512-4-6s6Rr6Cm9Y@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).