public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "anlauf at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/95512] gcc/fortran/trans-decl.c:1066: array sanity check after use Date: Sat, 06 Jun 2020 19:59:08 +0000 [thread overview] Message-ID: <bug-95512-4-bp87fy0F9i@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-95512-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95512 --- Comment #3 from anlauf at gcc dot gnu.org --- I didn't write the code, but for more context: trans.h has: #define GFC_TYPE_ARRAY_LBOUND(node, dim) \ (TYPE_LANG_SPECIFIC(node)->lbound[dim]) #define GFC_TYPE_ARRAY_UBOUND(node, dim) \ (TYPE_LANG_SPECIFIC(node)->ubound[dim]) The loop in trans-decl.c: for (dim = GFC_TYPE_ARRAY_RANK (type); dim < GFC_TYPE_ARRAY_RANK (type) + GFC_TYPE_ARRAY_CORANK (type); dim++) { if (GFC_TYPE_ARRAY_LBOUND (type, dim) == NULL_TREE) { GFC_TYPE_ARRAY_LBOUND (type, dim) = create_index_var ("lbound", nest); TREE_NO_WARNING (GFC_TYPE_ARRAY_LBOUND (type, dim)) = 1; } /* Don't try to use the unknown ubound for the last coarray dimension. */ if (GFC_TYPE_ARRAY_UBOUND (type, dim) == NULL_TREE && dim < GFC_TYPE_ARRAY_RANK (type) + GFC_TYPE_ARRAY_CORANK (type) - 1) { GFC_TYPE_ARRAY_UBOUND (type, dim) = create_index_var ("ubound", nest); TREE_NO_WARNING (GFC_TYPE_ARRAY_UBOUND (type, dim)) = 1; } } So the relevant check is in the loop header, and the current check is there for the last index. Maybe it is bad style, but I still consider it a false positive. cppcheck's view is probably too narrow to understand the range of dim.
next prev parent reply other threads:[~2020-06-06 19:59 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-03 19:46 [Bug fortran/95512] New: " dcb314 at hotmail dot com 2020-06-05 21:24 ` [Bug fortran/95512] " anlauf at gcc dot gnu.org 2020-06-06 6:26 ` dcb314 at hotmail dot com 2020-06-06 19:59 ` anlauf at gcc dot gnu.org [this message] 2020-06-06 20:42 ` dcb314 at hotmail dot com 2020-06-14 12:54 ` tkoenig at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-95512-4-bp87fy0F9i@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).