public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/95520] [coroutines] __builtin_FUNCTION() returns mangled .actor instead of original function name
Date: Mon, 19 Jul 2021 20:18:38 +0000	[thread overview]
Message-ID: <bug-95520-4-FlR8eTSDC2@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-95520-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95520

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>:

https://gcc.gnu.org/g:237ab3ee49e2f3110accfcc03b6c0df8b4889f15

commit r12-2400-g237ab3ee49e2f3110accfcc03b6c0df8b4889f15
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Thu Jul 8 09:42:49 2021 +0100

    coroutines: Adjust outlined function names [PR95520].

    The mechanism used to date for uniquing the coroutine helper
    functions (actor, destroy) was over-complicating things and
    leading to the noted PR and also difficulties in setting
    breakpoints on these functions (so this will help PR99215 as
    well).

    This implementation delegates the adjustment to the mangling
    to write_encoding() which necessitates some book-keeping so
    that it is possible to determine which of the coroutine
    helper names is to be mangled.

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

    PR c++/95520 - [coroutines] __builtin_FUNCTION() returns mangled .actor
instead of original function name

            PR c++/95520

    gcc/cp/ChangeLog:

            * coroutines.cc (struct coroutine_info): Add fields for
            actor and destroy function decls.
            (to_ramp): New.
            (coro_get_ramp_function): New.
            (coro_get_actor_function): New.
            (coro_get_destroy_function): New.
            (act_des_fn): Set up mapping between ramp, actor and
            destroy functions.
            (morph_fn_to_coro): Adjust interface to the builder for
            helper function decls.
            * cp-tree.h (DECL_ACTOR_FN, DECL_DESTROY_FN, DECL_RAMP_FN,
            JOIN_STR): New.
            * mangle.c (write_encoding): Handle coroutine helpers.
            (write_unqualified_name): Handle lambda coroutine helpers.

    gcc/testsuite/ChangeLog:

            * g++.dg/coroutines/pr95520.C: New test.

  parent reply	other threads:[~2021-07-19 20:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 23:42 [Bug c++/95520] New: " bruck.michael at gmail dot com
2020-06-04 19:57 ` [Bug c++/95520] " iains at gcc dot gnu.org
2020-07-23  6:51 ` rguenth at gcc dot gnu.org
2021-04-08 12:02 ` rguenth at gcc dot gnu.org
2021-05-04 12:32 ` rguenth at gcc dot gnu.org
2021-07-19 20:18 ` cvs-commit at gcc dot gnu.org [this message]
2021-07-20  6:56 ` cvs-commit at gcc dot gnu.org
2021-10-03 19:28 ` cvs-commit at gcc dot gnu.org
2021-10-03 19:39 ` iains at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-95520-4-FlR8eTSDC2@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).