public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug d/95575] New: [10/11 regression] gdc.test testnames lost gdc.test prefix
@ 2020-06-08 9:46 ro at gcc dot gnu.org
2020-06-08 9:46 ` [Bug d/95575] " ro at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: ro at gcc dot gnu.org @ 2020-06-08 9:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95575
Bug ID: 95575
Summary: [10/11 regression] gdc.test testnames lost gdc.test
prefix
Product: gcc
Version: 11.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: d
Assignee: ibuclaw at gdcproject dot org
Reporter: ro at gcc dot gnu.org
Target Milestone: ---
As originally reported here
https://gcc.gnu.org/pipermail/gcc-patches/2020-April/543045.html
this patch
commit c76df72f1a916d0482d15e43656ddff724352705
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date: Sat Mar 28 18:44:12 2020 +0100
testsuite: Split up gdc-test.exp into each subdirectory
again lost the gdc.test prefix in the testnames, as e.g. seen on Solaris:
-FAIL: gdc.test/runnable/eh.d -fPIC -shared-libphobos execution test
-FAIL: gdc.test/runnable/eh.d -shared-libphobos execution test
-FAIL: gdc.test/runnable/test42.d execution test
-FAIL: gdc.test/runnable/test42.d -g execution test
-FAIL: gdc.test/runnable/test42.d -g -shared-libphobos execution test
-FAIL: gdc.test/runnable/test42.d -shared-libphobos execution test
+FAIL: runnable/eh.d -fPIC -shared-libphobos execution test
+FAIL: runnable/eh.d -shared-libphobos execution test
+FAIL: runnable/test42.d execution test
+FAIL: runnable/test42.d -g execution test
+FAIL: runnable/test42.d -g -shared-libphobos execution test
+FAIL: runnable/test42.d -shared-libphobos execution test
The testnames are supposed to be relative to gcc/testsuite.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug d/95575] [10/11 regression] gdc.test testnames lost gdc.test prefix
2020-06-08 9:46 [Bug d/95575] New: [10/11 regression] gdc.test testnames lost gdc.test prefix ro at gcc dot gnu.org
@ 2020-06-08 9:46 ` ro at gcc dot gnu.org
2020-06-08 20:36 ` ibuclaw at gdcproject dot org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ro at gcc dot gnu.org @ 2020-06-08 9:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95575
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |10.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug d/95575] [10/11 regression] gdc.test testnames lost gdc.test prefix
2020-06-08 9:46 [Bug d/95575] New: [10/11 regression] gdc.test testnames lost gdc.test prefix ro at gcc dot gnu.org
2020-06-08 9:46 ` [Bug d/95575] " ro at gcc dot gnu.org
@ 2020-06-08 20:36 ` ibuclaw at gdcproject dot org
2020-06-09 8:24 ` ro at CeBiTec dot Uni-Bielefeld.DE
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ibuclaw at gdcproject dot org @ 2020-06-08 20:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95575
--- Comment #1 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
Ah, for some reason I thought that moving the dejagnu .exp scripts from
top-level gdc.test to one per each subdirectory would remove the need for that.
I'll revert that part of the change then.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug d/95575] [10/11 regression] gdc.test testnames lost gdc.test prefix
2020-06-08 9:46 [Bug d/95575] New: [10/11 regression] gdc.test testnames lost gdc.test prefix ro at gcc dot gnu.org
2020-06-08 9:46 ` [Bug d/95575] " ro at gcc dot gnu.org
2020-06-08 20:36 ` ibuclaw at gdcproject dot org
@ 2020-06-09 8:24 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-06-14 9:04 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2020-06-09 8:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95575
--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #1 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
> Ah, for some reason I thought that moving the dejagnu .exp scripts from
> top-level gdc.test to one per each subdirectory would remove the need for that.
No, exactly which driver files are used is an implementation detail: you
can run tests in subdirs either from a toplevel .exp file or from
separate per-subdir ones. What's important is keeping the test names
stable, otherwise this wreaks havoc with comparing test results.
> I'll revert that part of the change then.
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug d/95575] [10/11 regression] gdc.test testnames lost gdc.test prefix
2020-06-08 9:46 [Bug d/95575] New: [10/11 regression] gdc.test testnames lost gdc.test prefix ro at gcc dot gnu.org
` (2 preceding siblings ...)
2020-06-09 8:24 ` ro at CeBiTec dot Uni-Bielefeld.DE
@ 2020-06-14 9:04 ` cvs-commit at gcc dot gnu.org
2020-06-14 9:06 ` cvs-commit at gcc dot gnu.org
2020-06-14 9:13 ` ibuclaw at gdcproject dot org
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-06-14 9:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95575
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:
https://gcc.gnu.org/g:4a557dc45650bbe500276680674afa18d291fdcc
commit r11-1294-g4a557dc45650bbe500276680674afa18d291fdcc
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date: Sun Jun 14 11:02:52 2020 +0200
testsuite: Re-add gdc.test prefix in test names (PR testsuite/95575)
gcc/testsuite/ChangeLog:
PR testsuite/95575
* lib/gdc-utils.exp (gdc-do-test): Re-add $subdir link and
inclusion
in filename.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug d/95575] [10/11 regression] gdc.test testnames lost gdc.test prefix
2020-06-08 9:46 [Bug d/95575] New: [10/11 regression] gdc.test testnames lost gdc.test prefix ro at gcc dot gnu.org
` (3 preceding siblings ...)
2020-06-14 9:04 ` cvs-commit at gcc dot gnu.org
@ 2020-06-14 9:06 ` cvs-commit at gcc dot gnu.org
2020-06-14 9:13 ` ibuclaw at gdcproject dot org
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-06-14 9:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95575
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Iain Buclaw
<ibuclaw@gcc.gnu.org>:
https://gcc.gnu.org/g:892b4f74d9b05821f87fec9fc104fba6325972e1
commit r10-8291-g892b4f74d9b05821f87fec9fc104fba6325972e1
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date: Sun Jun 14 11:02:52 2020 +0200
testsuite: Re-add gdc.test prefix in test names (PR testsuite/95575)
gcc/testsuite/ChangeLog:
PR testsuite/95575
* lib/gdc-utils.exp (gdc-do-test): Re-add $subdir link and
inclusion
in filename.
(cherry picked from commit 4a557dc45650bbe500276680674afa18d291fdcc)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug d/95575] [10/11 regression] gdc.test testnames lost gdc.test prefix
2020-06-08 9:46 [Bug d/95575] New: [10/11 regression] gdc.test testnames lost gdc.test prefix ro at gcc dot gnu.org
` (4 preceding siblings ...)
2020-06-14 9:06 ` cvs-commit at gcc dot gnu.org
@ 2020-06-14 9:13 ` ibuclaw at gdcproject dot org
5 siblings, 0 replies; 7+ messages in thread
From: ibuclaw at gdcproject dot org @ 2020-06-14 9:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95575
Iain Buclaw <ibuclaw at gdcproject dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
Done.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-06-14 9:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-08 9:46 [Bug d/95575] New: [10/11 regression] gdc.test testnames lost gdc.test prefix ro at gcc dot gnu.org
2020-06-08 9:46 ` [Bug d/95575] " ro at gcc dot gnu.org
2020-06-08 20:36 ` ibuclaw at gdcproject dot org
2020-06-09 8:24 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-06-14 9:04 ` cvs-commit at gcc dot gnu.org
2020-06-14 9:06 ` cvs-commit at gcc dot gnu.org
2020-06-14 9:13 ` ibuclaw at gdcproject dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).