public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug bootstrap/95582] [11 Regression] LTO lean + PGO bootstrap is broken in Ada Date: Wed, 07 Oct 2020 10:02:16 +0000 [thread overview] Message-ID: <bug-95582-4-h9q4gsLhHr@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-95582-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95582 --- Comment #15 from Richard Biener <rguenth at gcc dot gnu.org> --- The patch causes g++.dg/vect/simd-bool-comparison-1.cc to FAIL because it will result in signed BOOLEAN_TYPEs with precision 1 rejected. Those we use for build_nonstandard_boolean_type via #0 0x0000000001b93458 in build_truth_vector_type_for_mode (nunits=..., mask_mode=E_DImode) at /home/rguenther/src/gcc3/gcc/tree.c:10931 #1 0x0000000001b935a2 in build_truth_vector_type_for (vectype=<vector_type 0x7ffff69c0bd0>) at /home/rguenther/src/gcc3/gcc/tree.c:10949 #2 0x0000000001b96175 in truth_type_for (type=<vector_type 0x7ffff69c0bd0>) at /home/rguenther/src/gcc3/gcc/tree.c:11764 #3 0x0000000001ae92b6 in get_mask_type_for_scalar_type (vinfo=0x3beccd0, scalar_type=<boolean_type 0x7ffff682bb28 bool>, group_size=0) at /home/rguenther/src/gcc3/gcc/tree-vect-stmts.c:11137 #4 0x00000000028cfaee in vect_recog_mask_conversion_pattern (vinfo=0x3beccd0, stmt_vinfo=0x3da6ae0, type_out=0x7fffffffc320) at /home/rguenther/src/gcc3/gcc/tree-vect-patterns.c:4354 which then causes the VECT_SCALAR_BOOLEAN_TYPE_P result to differ even for C++ at #1 0x0000000001abfa11 in VECT_SCALAR_BOOLEAN_TYPE_P (TYPE=<boolean_type 0x7ffff69c01f8>) at /home/rguenther/src/gcc3/gcc/tree-vectorizer.h:1425 #2 0x0000000001ae41c1 in vect_is_simple_cond (cond=<ssa_name 0x7ffff69cd828 22>, vinfo=0x3beccd0, stmt_info=0x3da7410, slp_node=0x0, comp_vectype=0x7fffffffbbe0, dts=0x7fffffffbbb0, vectype=<vector_type 0x7ffff68f7150>) at /home/rguenther/src/gcc3/gcc/tree-vect-stmts.c:9711 #3 0x0000000001ae49bf in vectorizable_condition (vinfo=0x3beccd0, stmt_info=0x3da7410, gsi=0x0, vec_stmt=0x0, slp_node=0x0, cost_vec=0x7fffffffc1b8) at /home/rguenther/src/gcc3/gcc/tree-vect-stmts.c:9876 now the Ada issue was about non-1 precision BOOLEAN_TYPE, so we could narrow down the fix. But then the question is why we allow signed 1-bit bools but not signed 1-bit integers... So I'm first re-testing #define VECT_SCALAR_BOOLEAN_TYPE_P(TYPE) \ - (TREE_CODE (TYPE) == BOOLEAN_TYPE \ - || ((TREE_CODE (TYPE) == INTEGER_TYPE \ - || TREE_CODE (TYPE) == ENUMERAL_TYPE) \ - && TYPE_PRECISION (TYPE) == 1 \ - && TYPE_UNSIGNED (TYPE))) + (INTEGRAL_TYPE_P (TYPE) \ + && TYPE_PRECISION (TYPE) == 1)
next prev parent reply other threads:[~2020-10-07 10:02 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-08 16:40 [Bug bootstrap/95582] New: " marxin at gcc dot gnu.org 2020-06-09 6:59 ` [Bug bootstrap/95582] " rguenth at gcc dot gnu.org 2020-06-09 7:31 ` marxin at gcc dot gnu.org 2020-06-09 8:10 ` marxin at gcc dot gnu.org 2020-06-09 8:14 ` marxin at gcc dot gnu.org 2020-06-09 8:25 ` marxin at gcc dot gnu.org 2020-06-09 8:47 ` rguenth at gcc dot gnu.org 2020-06-09 8:52 ` rguenth at gcc dot gnu.org 2020-06-09 9:40 ` ebotcazou at gcc dot gnu.org 2020-06-09 10:38 ` rguenther at suse dot de 2020-06-09 11:23 ` ebotcazou at gcc dot gnu.org 2020-08-27 12:40 ` marxin at gcc dot gnu.org 2020-08-27 12:55 ` rguenth at gcc dot gnu.org 2020-08-27 13:24 ` marxin at gcc dot gnu.org 2020-10-02 13:05 ` marxin at gcc dot gnu.org 2020-10-07 10:02 ` rguenth at gcc dot gnu.org [this message] 2020-10-07 11:42 ` rguenth at gcc dot gnu.org 2020-10-07 12:38 ` rguenth at gcc dot gnu.org 2020-12-07 10:05 ` marxin at gcc dot gnu.org 2020-12-10 14:01 ` rguenth at gcc dot gnu.org 2020-12-10 14:21 ` ebotcazou at gcc dot gnu.org 2020-12-11 8:23 ` rguenth at gcc dot gnu.org 2020-12-11 9:10 ` cvs-commit at gcc dot gnu.org 2020-12-11 9:49 ` rguenth at gcc dot gnu.org 2021-01-06 9:21 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-95582-4-h9q4gsLhHr@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).