public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/95582] [11 Regression] LTO lean + PGO bootstrap is broken in Ada
Date: Tue, 09 Jun 2020 08:52:52 +0000	[thread overview]
Message-ID: <bug-95582-4-jJMr2LfyNg@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-95582-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95582

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
So Ada does

  /* In Ada, we use an unsigned 8-bit type for the default boolean type.  */
  boolean_type_node = make_unsigned_type (8);
  TREE_SET_CODE (boolean_type_node, BOOLEAN_TYPE);

but somehow in lto1 (or via pulling in C code into the LTRANS function?)
lto1 boolean_type_node is the 1-bit one.  So that's probably introducing
the mismatch (and eventually missed optimizations with -flto and Ada).

We're excempting boolean type from special streaming correctly:

    /* Skip boolean type and constants, they are frontend dependent.  */
    if (i != TI_BOOLEAN_TYPE
        && i != TI_BOOLEAN_FALSE
        && i != TI_BOOLEAN_TRUE

but of course then all middle-end (at lto1 time) generated expressions
with boolean type get to use the lto1 boolean_type_node which matches
that of the C frontend.

So a testcase will need both Ada and LTO to trigger the issue.

  parent reply	other threads:[~2020-06-09  8:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08 16:40 [Bug bootstrap/95582] New: " marxin at gcc dot gnu.org
2020-06-09  6:59 ` [Bug bootstrap/95582] " rguenth at gcc dot gnu.org
2020-06-09  7:31 ` marxin at gcc dot gnu.org
2020-06-09  8:10 ` marxin at gcc dot gnu.org
2020-06-09  8:14 ` marxin at gcc dot gnu.org
2020-06-09  8:25 ` marxin at gcc dot gnu.org
2020-06-09  8:47 ` rguenth at gcc dot gnu.org
2020-06-09  8:52 ` rguenth at gcc dot gnu.org [this message]
2020-06-09  9:40 ` ebotcazou at gcc dot gnu.org
2020-06-09 10:38 ` rguenther at suse dot de
2020-06-09 11:23 ` ebotcazou at gcc dot gnu.org
2020-08-27 12:40 ` marxin at gcc dot gnu.org
2020-08-27 12:55 ` rguenth at gcc dot gnu.org
2020-08-27 13:24 ` marxin at gcc dot gnu.org
2020-10-02 13:05 ` marxin at gcc dot gnu.org
2020-10-07 10:02 ` rguenth at gcc dot gnu.org
2020-10-07 11:42 ` rguenth at gcc dot gnu.org
2020-10-07 12:38 ` rguenth at gcc dot gnu.org
2020-12-07 10:05 ` marxin at gcc dot gnu.org
2020-12-10 14:01 ` rguenth at gcc dot gnu.org
2020-12-10 14:21 ` ebotcazou at gcc dot gnu.org
2020-12-11  8:23 ` rguenth at gcc dot gnu.org
2020-12-11  9:10 ` cvs-commit at gcc dot gnu.org
2020-12-11  9:49 ` rguenth at gcc dot gnu.org
2021-01-06  9:21 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-95582-4-jJMr2LfyNg@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).