From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id E53D5388A82A; Tue, 9 Jun 2020 21:41:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E53D5388A82A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1591738905; bh=3Z/jlDHcZS0ma7RgbTweE/vfZuLmnQ/CUC0nvwCCyGM=; h=From:To:Subject:Date:In-Reply-To:References:From; b=FAVdA1EaXSZmpGa/zOVRHen5NNJgEhbjOcZqVL+2up/P8fc1jYCuKXYlpoSWxOx0k TSp1rOqS0B0K3L5xYnZV5XHR4ugU1c3EdB9SjB4puBpxpwxMlvtcBaJ+JUGrugDqgH TGvyIfmVFm6oF/HcfXLKDiZwfYqKvLTnD+55HG5A= From: "kargl at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/95614] ICE in build_field, at fortran/trans-common.c:301 Date: Tue, 09 Jun 2020 21:41:45 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: fortran X-Bugzilla-Version: 11.0 X-Bugzilla-Keywords: ice-on-invalid-code X-Bugzilla-Severity: normal X-Bugzilla-Who: kargl at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P4 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc priority Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2020 21:41:46 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D95614 kargl at gcc dot gnu.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kargl at gcc dot gnu.org Priority|P3 |P4 --- Comment #2 from kargl at gcc dot gnu.org --- Index: gcc/fortran/decl.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gcc/fortran/decl.c (revision 280157) +++ gcc/fortran/decl.c (working copy) @@ -5924,7 +5924,7 @@ get_bind_c_idents (void) found_id =3D MATCH_YES; gfc_get_ha_symbol (name, &tmp_sym); } - else if (match_common_name (name) =3D=3D MATCH_YES) + else if (gfc_match_common_name (name) =3D=3D MATCH_YES) { found_id =3D MATCH_YES; com_block =3D gfc_get_common (name, 0); @@ -5969,7 +5969,7 @@ get_bind_c_idents (void) found_id =3D MATCH_YES; gfc_get_ha_symbol (name, &tmp_sym); } - else if (match_common_name (name) =3D=3D MATCH_YES) + else if (gfc_match_common_name (name) =3D=3D MATCH_YES) { found_id =3D MATCH_YES; com_block =3D gfc_get_common (name, 0); Index: gcc/fortran/match.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gcc/fortran/match.c (revision 280157) +++ gcc/fortran/match.c (working copy) @@ -5122,7 +5122,8 @@ gfc_get_common (const char *name, int from_module) /* Match a common block name. */ -match match_common_name (char *name) +match +gfc_match_common_name (char *name) { match m; @@ -5174,7 +5175,7 @@ gfc_match_common (void) for (;;) { - m =3D match_common_name (name); + m =3D gfc_match_common_name (name); if (m =3D=3D MATCH_ERROR) goto cleanup; Index: gcc/fortran/match.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gcc/fortran/match.h (revision 280157) +++ gcc/fortran/match.h (working copy) @@ -103,11 +103,8 @@ match gfc_match_call (void); /* We want to use this function to check for a common-block-name that can exist in a bind statement, so removed the "static" - declaration of the function in match.c. -=20 - TODO: should probably rename this now that it'll be globally seen to - gfc_match_common_name. */ -match match_common_name (char *name); + declaration of the function in match.c. */ +match gfc_match_common_name (char *name); match gfc_match_common (void); match gfc_match_block_data (void); Index: gcc/fortran/resolve.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gcc/fortran/resolve.c (revision 280157) +++ gcc/fortran/resolve.c (working copy) @@ -936,9 +936,16 @@ static void resolve_common_vars (gfc_common_head *common_block, bool named_common) { gfc_symbol *csym =3D common_block->head; + gfc_gsymbol *gsym; for (; csym; csym =3D csym->common_next) { + gsym =3D gfc_find_gsymbol (gfc_gsym_root, csym->name); + if (gsym && gsym->type !=3D GSYM_UNKNOWN) + gfc_error_now ("Global entity %qs at %L cannot appear in a " + "COMMON block at %L", gsym->name, + &gsym->where, &csym->common_block->where); + /* gfc_add_in_common may have been called before, but the reported errors have been ignored to continue parsing. We do the checks again here. */=