public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/95663] static_cast checks for null even when the pointer is dereferenced Date: Sat, 27 Jun 2020 15:57:24 +0000 [thread overview] Message-ID: <bug-95663-4-ZVirs3T7dJ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-95663-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95663 --- Comment #15 from Jakub Jelinek <jakub at gcc dot gnu.org> --- In the particular case we are talking about, security/non-security, it doesn't make sense to do anything but optimize it into straight line code, any __builtin_trap or similar will just hurt. If you feel e.g. by default adding __builtin_unreachable is too dangerous in some cases, it can just handle similar cases manually and optimize away the conditional if there are no side-effect statements in between. We are talking about: <bb 2> [local count: 1073741824]: if (base_2(D) != 0B) goto <bb 3>; [70.00%] else goto <bb 4>; [30.00%] <bb 3> [local count: 751619281]: iftmp.1_3 = base_2(D) + (sizetype)-4; <bb 4> [local count: 1073741824]: # iftmp.1_1 = PHI <iftmp.1_3(3), 0B(2)> _5 = MEM[(const struct Derived *)iftmp.1_1].D.2340.y; where without -fno-delete-null-pointer-checks and without -fwrapv-pointer, we can assume: 1) pointers in valid programs don't wrap 2) the first page is not mapped As offsetof (Derived, D.2340.y) is >= 4 and < 4096 here, we don't need to even care about pointer wrapping, just rely on accesses to 0 .. 4095 offsets to trap. If the offsetof would be 0, it would be about pointer wrapping, whether we are ok if instead of dereferencing *(int *)0 we dereference *(int *)-4 instead.
next prev parent reply other threads:[~2020-06-27 15:57 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-13 10:52 [Bug c++/95663] New: " jzwinck at gmail dot com 2020-06-15 6:47 ` [Bug tree-optimization/95663] " rguenth at gcc dot gnu.org 2020-06-15 10:04 ` redi at gcc dot gnu.org 2020-06-15 10:09 ` redi at gcc dot gnu.org 2020-06-15 11:46 ` jzwinck at gmail dot com 2020-06-15 12:50 ` rguenther at suse dot de 2020-06-15 12:53 ` redi at gcc dot gnu.org 2020-06-15 12:54 ` redi at gcc dot gnu.org 2020-06-15 13:03 ` rguenther at suse dot de 2020-06-15 13:32 ` jakub at gcc dot gnu.org 2020-06-26 22:18 ` law at redhat dot com 2020-06-27 0:20 ` jzwinck at gmail dot com 2020-06-27 11:49 ` glisse at gcc dot gnu.org 2020-06-27 15:36 ` law at redhat dot com 2020-06-27 15:40 ` law at redhat dot com 2020-06-27 15:57 ` jakub at gcc dot gnu.org [this message] 2021-01-07 13:13 ` redi at gcc dot gnu.org 2021-01-07 13:14 ` redi at gcc dot gnu.org 2021-01-07 20:00 ` law at redhat dot com 2021-12-13 11:05 ` hubicka at gcc dot gnu.org 2021-12-13 11:10 ` hubicka at gcc dot gnu.org 2021-12-13 15:51 ` law at gcc dot gnu.org 2022-01-03 9:54 ` rguenther at suse dot de
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-95663-4-ZVirs3T7dJ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).