[Bug target/95683] New: internal compiler error: in riscv_gpr_save_operation_p, at config/riscv/riscv.c:5219

[Bug target/95683] New: internal compiler error: in riscv_gpr_save_operation_p, at config/riscv/riscv.c:5219

[kito.cheng at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95683

            Bug ID: 95683
           Summary: internal compiler error: in
                    riscv_gpr_save_operation_p, at
                    config/riscv/riscv.c:5219
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: kito.cheng at gmail dot com
  Target Milestone: ---
            Target: riscv64-unknown-elf

Report by Pat Pannuto at github:
https://github.com/riscv/riscv-gcc/issues/190

Testcase:

void a() {
  asm(""
      :
      :
      : "a0", "a1", "a2", "a3", "a4", "a5", "a6", "a7", "t0", "t1", "t2", "t3",
        "t4", "t5", "t6", "ra");
}

Error message:
during RTL pass: ira
/scratch1/kitoc/riscv-gnu-workspace/riscv-gnu-toolchain-trunk/riscv-gcc/gcc/testsuite/gcc.target/riscv/pr95252-2.c:
In function 'a':
/scratch1/kitoc/riscv-gnu-workspace/riscv-gnu-toolchain-trunk/riscv-gcc/gcc/testsuite/gcc.target/riscv/pr95252-2.c:10:1:
internal compiler error: in riscv_gpr_save_operation_p, at
config/riscv/riscv.c:5219
   10 | }
      | ^
0x1662745 riscv_gpr_save_operation_p(rtx_def*)
       
../../../../riscv-gnu-toolchain-trunk/riscv-gcc/gcc/config/riscv/riscv.c:5219
0x1a6829d gpr_save_operation_1
       
../../../../riscv-gnu-toolchain-trunk/riscv-gcc/gcc/config/riscv/predicates.md:213
0x1a682cf gpr_save_operation(rtx_def*, machine_mode)
       
../../../../riscv-gnu-toolchain-trunk/riscv-gcc/gcc/config/riscv/predicates.md:220
0x1a7e441 recog(rtx_def*, rtx_insn*, int*)
       
../../../../riscv-gnu-toolchain-trunk/riscv-gcc/gcc/config/riscv/riscv.md:2499
0x10cdd2c recog_memoized
        ../../../../riscv-gnu-toolchain-trunk/riscv-gcc/gcc/recog.h:167
0x10d6dd8 elimination_costs_in_insn
        ../../../../riscv-gnu-toolchain-trunk/riscv-gcc/gcc/reload1.c:3525
0x10d1aa1 calculate_elim_costs_all_insns()
        ../../../../riscv-gnu-toolchain-trunk/riscv-gcc/gcc/reload1.c:1604
0xeba7fc ira_costs()
        ../../../../riscv-gnu-toolchain-trunk/riscv-gcc/gcc/ira-costs.c:2293
0xeb0b2d ira_build()
        ../../../../riscv-gnu-toolchain-trunk/riscv-gcc/gcc/ira-build.c:3432
0xea6877 ira
        ../../../../riscv-gnu-toolchain-trunk/riscv-gcc/gcc/ira.c:5353
0xea70f4 execute
        ../../../../riscv-gnu-toolchain-trunk/riscv-gcc/gcc/ira.c:5666
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug target/95683] RISC-V: internal compiler error: in riscv_gpr_save_operation_p, at config/riscv/riscv.c:5219

[kito at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95683

Kito Cheng <kito at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2020-06-15
             Status|UNCONFIRMED                 |ASSIGNED
                 CC|                            |kito at gcc dot gnu.org
     Ever confirmed|0                           |1

[Bug target/95683] RISC-V: internal compiler error: in riscv_gpr_save_operation_p, at config/riscv/riscv.c:5219

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95683

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Kito Cheng <kito@gcc.gnu.org>:

https://gcc.gnu.org/g:beaf12b49ae030505194cdcac18b5c8533a43921

commit r11-1346-gbeaf12b49ae030505194cdcac18b5c8533a43921
Author: Kito Cheng <kito.cheng@sifive.com>
Date:   Tue Jun 16 10:14:13 2020 +0800

    RISC-V: Fix ICE on riscv_gpr_save_operation_p [PR95683]

     - riscv_gpr_save_operation_p might try to match parallel on other
       patterns like inline asm pattern, and then it might trigger ther
       assertion checking there, so we could trun it into a early exit check.

    gcc/ChangeLog:

            PR target/95683
            * config/riscv/riscv.c (riscv_gpr_save_operation_p): Remove
            assertion and turn it into a early exit check.

    gcc/testsuite/ChangeLog

            PR target/95683
            * gcc.target/riscv/pr95683.c: New.

[Bug target/95683] RISC-V: internal compiler error: in riscv_gpr_save_operation_p, at config/riscv/riscv.c:5219

[kito at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95683

Kito Cheng <kito at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Kito Cheng <kito at gcc dot gnu.org> ---
Fixed on trunk.

[Bug target/95683] RISC-V: internal compiler error: in riscv_gpr_save_operation_p, at config/riscv/riscv.c:5219

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95683

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Kito Cheng <kito@gcc.gnu.org>:

https://gcc.gnu.org/g:01b774ff3adcae0e72548f050795c1cf6bf5b8fe

commit r10-8445-g01b774ff3adcae0e72548f050795c1cf6bf5b8fe
Author: Kito Cheng <kito.cheng@sifive.com>
Date:   Tue Jun 16 10:14:13 2020 +0800

    RISC-V: Fix ICE on riscv_gpr_save_operation_p [PR95683]

     - riscv_gpr_save_operation_p might try to match parallel on other
       patterns like inline asm pattern, and then it might trigger ther
       assertion checking there, so we could trun it into a early exit check.

    gcc/ChangeLog:

            PR target/95683
            * config/riscv/riscv.c (riscv_gpr_save_operation_p): Remove
            assertion and turn it into a early exit check.

    gcc/testsuite/ChangeLog

            PR target/95683
            * gcc.target/riscv/pr95683.c: New.

    (cherry picked from commit beaf12b49ae030505194cdcac18b5c8533a43921)