public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/95714] New: Poor locations for errors in calls to __atomic built-ins Date: Tue, 16 Jun 2020 22:03:35 +0000 [thread overview] Message-ID: <bug-95714-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95714 Bug ID: 95714 Summary: Poor locations for errors in calls to __atomic built-ins Product: gcc Version: 10.0 Status: UNCONFIRMED Keywords: diagnostic Severity: normal Priority: P3 Component: c Assignee: unassigned at gcc dot gnu.org Reporter: redi at gcc dot gnu.org Target Milestone: --- int main() { char c; int i; __atomic_load(&c, &i, __ATOMIC_SEQ_CST); } The C compiler says: ab.cc: In function 'main': ab.cc:5:3: error: size mismatch in argument 2 of '__atomic_load' 5 | __atomic_load(&c, &i, __ATOMIC_SEQ_CST); | ^~~~~~~~~~~~~ and the C++ compiler says: ab.cc: In function 'int main()': ab.cc:5:41: error: size mismatch in argument 2 of '__atomic_load' 5 | __atomic_load(&c, &i, __ATOMIC_SEQ_CST); | ^ Both are poor. Instead of saying "argument 2" and highlighting the function name or the end of the argument list, we should highlight the relevant argument: ab.cc: In function 'main': ab.cc:5:3: error: size mismatch in argument 2 of '__atomic_load' 5 | __atomic_load(&c, &i, __ATOMIC_SEQ_CST); | ^~ Even better would be: ab.cc: In function 'main': ab.cc:5:3: error: size mismatch in argument 2 of '__atomic_load' 5 | __atomic_load(&c, &i, __ATOMIC_SEQ_CST); | ^~ ^~ | | | | | int* | char*
next reply other threads:[~2020-06-16 22:03 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-16 22:03 redi at gcc dot gnu.org [this message] 2021-05-30 22:25 ` [Bug c/95714] " pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-95714-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).