From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 86BBB3840C1B; Sat, 20 Jun 2020 15:48:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 86BBB3840C1B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1592668095; bh=JLxwJMwBCYBSS0yKVWiJrgF0ydlF5uHh35TiSK/Lc4w=; h=From:To:Subject:Date:In-Reply-To:References:From; b=HaKDa4IYPxDo31nDkn647R5tLHhXN59J/QlvzjdB5w7xhyl0SYEuATgj7oUXuym7I WVgMwGisNE9tKjhGOmGFQCiNPOaT/m3U9ztsrY6VR19fi11JMrgLoq33oQMMOV4Mxp KFZFa9JEmKylVhcMGFmhk48cVRR0UR0cDR/YwvSM= From: "yyc1992 at gmail dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug other/95778] target_clones indirection eliminates requires noinline Date: Sat, 20 Jun 2020 15:48:15 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: other X-Bugzilla-Version: 10.1.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: yyc1992 at gmail dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jun 2020 15:48:15 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D95778 --- Comment #1 from Yichao Yu --- Ah, I think this might be the fix for both this issue and https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D95780 . I'll test more and w= ill try to submit it later. ``` diff --git a/gcc/multiple_target.c b/gcc/multiple_target.c index c1cfe8ff978..79a4c87545f 100644 --- a/gcc/multiple_target.c +++ b/gcc/multiple_target.c @@ -483,7 +483,7 @@ redirect_to_specific_clone (cgraph_node *node) DECL_ATTRIBUTES (e->callee->dec= l)); /* Function is not calling proper target clone. */ - if (!attribute_list_equal (attr_target, attr_target2)) + if (!attribute_value_equal (attr_target, attr_target2)) { while (fv2->prev !=3D NULL) fv2 =3D fv2->prev; @@ -494,7 +494,7 @@ redirect_to_specific_clone (cgraph_node *node) cgraph_node *callee =3D fv2->this_node; attr_target2 =3D lookup_attribute ("target", DECL_ATTRIBUTES (callee->dec= l)); - if (attribute_list_equal (attr_target, attr_target2)) + if (attribute_value_equal (attr_target, attr_target2)) { e->redirect_callee (callee); cgraph_edge::redirect_call_stmt_to_callee (e); ```=