public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "felix.von.s at posteo dot de" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/95801] New: Optimiser does not exploit the fact that an integer divisor cannot be zero Date: Sun, 21 Jun 2020 12:29:03 +0000 [thread overview] Message-ID: <bug-95801-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95801 Bug ID: 95801 Summary: Optimiser does not exploit the fact that an integer divisor cannot be zero Product: gcc Version: 11.0 Status: UNCONFIRMED Keywords: missed-optimization Severity: normal Priority: P3 Component: tree-optimization Assignee: unassigned at gcc dot gnu.org Reporter: felix.von.s at posteo dot de Target Milestone: --- int always1(int a, int b) { if (a / b) return b != 0; return 1; } The function above should be possible to optimise to a constant 1, as integer division by zero is undefined. I’m surprised this isn’t caught already; it seems like very low-hanging fruit. In case someone wants to claim there is no value to be gained from this, this is where it came up: #define SIGNUM(value) ({ \ __auto_type _value = (value); \ (__typeof__(_value)) ((_value > 0) - (_value < 0)); \ }) #define DIV_FLOOR(a, b) ({ \ __auto_type _a = (a); \ __auto_type _b = (b); \ (_a / _b) - ((SIGNUM(_a) != SIGNUM(_b) ? _a % _b : 0) != 0); \ }) For unsigned types, DIV_FLOOR(a, b) should compile to the same code as truncating division (a / b), but unless a statement to the effect of (b == 0 ? __builtin_unreachable() : (void) 0); is inserted before the division, DIV_FLOOR will generate considerably longer code, at least on x86.
next reply other threads:[~2020-06-21 12:29 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-21 12:29 felix.von.s at posteo dot de [this message] 2020-06-21 18:55 ` [Bug tree-optimization/95801] " glisse at gcc dot gnu.org 2020-06-22 8:39 ` rguenth at gcc dot gnu.org 2020-06-22 8:40 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-95801-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).