public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/95812] New: [10/11 Regression] ICE in gfc_dep_resolver since r10-2114
@ 2020-06-22 8:38 jakub at gcc dot gnu.org
2020-06-22 8:39 ` [Bug fortran/95812] " jakub at gcc dot gnu.org
` (11 more replies)
0 siblings, 12 replies; 13+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-06-22 8:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95812
Bug ID: 95812
Summary: [10/11 Regression] ICE in gfc_dep_resolver since
r10-2114
Product: gcc
Version: 10.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
Assignee: unassigned at gcc dot gnu.org
Reporter: jakub at gcc dot gnu.org
Target Milestone: ---
Starting with r10-2114-g40e1ed26774b7b6c24d166489a715aa75843ab36 Fortran FE
ICEs with -O3 on:
module test
contains
subroutine foo()
integer :: a(3)
a = 1
print *, matmul(1*reshape(a,(/3,1/)), reshape((/1,1,1/),(/1,3/)))
end subroutine foo
subroutine bar()
call foo()
end subroutine bar
end module test
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug fortran/95812] [10/11 Regression] ICE in gfc_dep_resolver since r10-2114
2020-06-22 8:38 [Bug fortran/95812] New: [10/11 Regression] ICE in gfc_dep_resolver since r10-2114 jakub at gcc dot gnu.org
@ 2020-06-22 8:39 ` jakub at gcc dot gnu.org
2020-06-22 8:50 ` rguenth at gcc dot gnu.org
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-06-22 8:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95812
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
CC| |tkoenig at gcc dot gnu.org
Last reconfirmed| |2020-06-22
Ever confirmed|0 |1
Target Milestone|--- |10.2
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug fortran/95812] [10/11 Regression] ICE in gfc_dep_resolver since r10-2114
2020-06-22 8:38 [Bug fortran/95812] New: [10/11 Regression] ICE in gfc_dep_resolver since r10-2114 jakub at gcc dot gnu.org
2020-06-22 8:39 ` [Bug fortran/95812] " jakub at gcc dot gnu.org
@ 2020-06-22 8:50 ` rguenth at gcc dot gnu.org
2020-06-22 9:38 ` tkoenig at gcc dot gnu.org
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-06-22 8:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95812
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P4
Keywords| |ice-on-valid-code
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug fortran/95812] [10/11 Regression] ICE in gfc_dep_resolver since r10-2114
2020-06-22 8:38 [Bug fortran/95812] New: [10/11 Regression] ICE in gfc_dep_resolver since r10-2114 jakub at gcc dot gnu.org
2020-06-22 8:39 ` [Bug fortran/95812] " jakub at gcc dot gnu.org
2020-06-22 8:50 ` rguenth at gcc dot gnu.org
@ 2020-06-22 9:38 ` tkoenig at gcc dot gnu.org
2020-06-22 22:35 ` tkoenig at gcc dot gnu.org
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2020-06-22 9:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95812
Thomas Koenig <tkoenig at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |tkoenig at gcc dot gnu.org
--- Comment #1 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
I'll take a look.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug fortran/95812] [10/11 Regression] ICE in gfc_dep_resolver since r10-2114
2020-06-22 8:38 [Bug fortran/95812] New: [10/11 Regression] ICE in gfc_dep_resolver since r10-2114 jakub at gcc dot gnu.org
` (2 preceding siblings ...)
2020-06-22 9:38 ` tkoenig at gcc dot gnu.org
@ 2020-06-22 22:35 ` tkoenig at gcc dot gnu.org
2020-06-23 6:15 ` cvs-commit at gcc dot gnu.org
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2020-06-22 22:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95812
--- Comment #2 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Fix looks simple enough:
diff --git a/gcc/fortran/dependency.c b/gcc/fortran/dependency.c
index f6c68409e68..7edd5d9010d 100644
--- a/gcc/fortran/dependency.c
+++ b/gcc/fortran/dependency.c
@@ -2031,10 +2031,12 @@ ref_same_as_full_array (gfc_ref *full_ref, gfc_ref
*ref)
return false;
if (full_ref->u.ar.type != AR_FULL)
return false;
if (ref->type != REF_ARRAY)
return false;
+ if (ref->u.ar.type == AR_FULL)
+ return true;
if (ref->u.ar.type != AR_SECTION)
return false;
for (i = 0; i < ref->u.ar.dimen; i++)
{
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug fortran/95812] [10/11 Regression] ICE in gfc_dep_resolver since r10-2114
2020-06-22 8:38 [Bug fortran/95812] New: [10/11 Regression] ICE in gfc_dep_resolver since r10-2114 jakub at gcc dot gnu.org
` (3 preceding siblings ...)
2020-06-22 22:35 ` tkoenig at gcc dot gnu.org
@ 2020-06-23 6:15 ` cvs-commit at gcc dot gnu.org
2020-06-23 13:23 ` cvs-commit at gcc dot gnu.org
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-06-23 6:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95812
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Thomas Kथà¤nig <tkoenig@gcc.gnu.org>:
https://gcc.gnu.org/g:abcde0a658e17dbbabcb396eaae5a3612e07d401
commit r11-1595-gabcde0a658e17dbbabcb396eaae5a3612e07d401
Author: Thomas Koenig <tkoenig@gcc.gnu.org>
Date: Tue Jun 23 08:14:51 2020 +0200
Handle AR_FULL vs. AR_FULL in dependency checking.
Previously, handling of full vs. full references failed to take
AR_FULL vs. AR_FULL into account. A change in dependency
checking in gcc 10 created a code path that could lead there;
with this patch, this is now correctly handled.
gcc/fortran/ChangeLog:
2020-06-23 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/95812
* dependency.c (ref_same_as_full_array): Handle case of AR_FULL
vs. AR_FULL.
gcc/testsuite/ChangeLog:
2020-06-23 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/95812
* gfortran.dg/dependency_59.f90: New test.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug fortran/95812] [10/11 Regression] ICE in gfc_dep_resolver since r10-2114
2020-06-22 8:38 [Bug fortran/95812] New: [10/11 Regression] ICE in gfc_dep_resolver since r10-2114 jakub at gcc dot gnu.org
` (4 preceding siblings ...)
2020-06-23 6:15 ` cvs-commit at gcc dot gnu.org
@ 2020-06-23 13:23 ` cvs-commit at gcc dot gnu.org
2020-06-23 13:23 ` tkoenig at gcc dot gnu.org
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-06-23 13:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95812
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Thomas Kथà¤nig
<tkoenig@gcc.gnu.org>:
https://gcc.gnu.org/g:2e4d807085a1cfd68ae79cb1abbe15114964a921
commit r10-8354-g2e4d807085a1cfd68ae79cb1abbe15114964a921
Author: Thomas Koenig <tkoenig@gcc.gnu.org>
Date: Tue Jun 23 08:14:51 2020 +0200
Handle AR_FULL vs. AR_FULL in dependency checking.
Previously, handling of full vs. full references failed to take
AR_FULL vs. AR_FULL into account. A change in dependency
checking in gcc 10 created a code path that could lead there;
with this patch, this is now correctly handled.
gcc/fortran/ChangeLog:
2020-06-23 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/95812
* dependency.c (ref_same_as_full_array): Handle case of AR_FULL
vs. AR_FULL.
gcc/testsuite/ChangeLog:
2020-06-23 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/95812
* gfortran.dg/dependency_59.f90: New test.
(cherry picked from commit abcde0a658e17dbbabcb396eaae5a3612e07d401)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug fortran/95812] [10/11 Regression] ICE in gfc_dep_resolver since r10-2114
2020-06-22 8:38 [Bug fortran/95812] New: [10/11 Regression] ICE in gfc_dep_resolver since r10-2114 jakub at gcc dot gnu.org
` (5 preceding siblings ...)
2020-06-23 13:23 ` cvs-commit at gcc dot gnu.org
@ 2020-06-23 13:23 ` tkoenig at gcc dot gnu.org
2020-06-23 16:47 ` dominiq at lps dot ens.fr
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2020-06-23 13:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95812
Thomas Koenig <tkoenig at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Fixed, closing.
Thanks for the bug report!
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug fortran/95812] [10/11 Regression] ICE in gfc_dep_resolver since r10-2114
2020-06-22 8:38 [Bug fortran/95812] New: [10/11 Regression] ICE in gfc_dep_resolver since r10-2114 jakub at gcc dot gnu.org
` (6 preceding siblings ...)
2020-06-23 13:23 ` tkoenig at gcc dot gnu.org
@ 2020-06-23 16:47 ` dominiq at lps dot ens.fr
2020-06-23 17:33 ` tkoenig at gcc dot gnu.org
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2020-06-23 16:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95812
Dominique d'Humieres <dominiq at lps dot ens.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
--- Comment #6 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
FAIL: gfortran.fortran-torture/execute/forall_5.f90 execution, -O0
FAIL: gfortran.fortran-torture/execute/forall_5.f90 execution, -O1
FAIL: gfortran.fortran-torture/execute/forall_5.f90 execution, -O2
FAIL: gfortran.fortran-torture/execute/forall_5.f90 execution, -O2
-fbounds-check
FAIL: gfortran.fortran-torture/execute/forall_5.f90 execution, -O2
-fomit-frame-pointer -finline-functions
FAIL: gfortran.fortran-torture/execute/forall_5.f90 execution, -O2
-fomit-frame-pointer -finline-functions -funroll-loops
FAIL: gfortran.fortran-torture/execute/forall_5.f90 execution, -O3 -g
FAIL: gfortran.fortran-torture/execute/forall_5.f90 execution, -Os
FAIL: gfortran.fortran-torture/execute/forall_5.f90 execution, -O2
-ftree-vectorize -maltivec
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug fortran/95812] [10/11 Regression] ICE in gfc_dep_resolver since r10-2114
2020-06-22 8:38 [Bug fortran/95812] New: [10/11 Regression] ICE in gfc_dep_resolver since r10-2114 jakub at gcc dot gnu.org
` (7 preceding siblings ...)
2020-06-23 16:47 ` dominiq at lps dot ens.fr
@ 2020-06-23 17:33 ` tkoenig at gcc dot gnu.org
2020-06-23 20:01 ` tkoenig at gcc dot gnu.org
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2020-06-23 17:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95812
--- Comment #7 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
The test case is invalid, see
https://gcc.gnu.org/pipermail/fortran/2020-June/054579.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug fortran/95812] [10/11 Regression] ICE in gfc_dep_resolver since r10-2114
2020-06-22 8:38 [Bug fortran/95812] New: [10/11 Regression] ICE in gfc_dep_resolver since r10-2114 jakub at gcc dot gnu.org
` (8 preceding siblings ...)
2020-06-23 17:33 ` tkoenig at gcc dot gnu.org
@ 2020-06-23 20:01 ` tkoenig at gcc dot gnu.org
2020-06-23 20:12 ` cvs-commit at gcc dot gnu.org
2020-06-23 20:13 ` tkoenig at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2020-06-23 20:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95812
--- Comment #8 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
https://gcc.gnu.org/g:6f609029c7078fbd29e2f842074e2b99ea099096
commit r11-1614-g6f609029c7078fbd29e2f842074e2b99ea099096
Author: Thomas Koenig <tkoenig@gcc.gnu.org>
Date: Tue Jun 23 21:59:47 2020 +0200
Make forall statement in testsuite conforming.
The recent patch for dependency checking introduced one failing test
case for pointer assignments in a forall statement. This test case
was invalid because of an interdependency in a forall statement.
This patch fixes that by removing that dependency.
gcc/testsuite/ChangeLog:
* gfortran.fortran-torture/execute/forall_5.f90: Make forall
statement conforming.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug fortran/95812] [10/11 Regression] ICE in gfc_dep_resolver since r10-2114
2020-06-22 8:38 [Bug fortran/95812] New: [10/11 Regression] ICE in gfc_dep_resolver since r10-2114 jakub at gcc dot gnu.org
` (9 preceding siblings ...)
2020-06-23 20:01 ` tkoenig at gcc dot gnu.org
@ 2020-06-23 20:12 ` cvs-commit at gcc dot gnu.org
2020-06-23 20:13 ` tkoenig at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-06-23 20:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95812
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Thomas Kथà¤nig
<tkoenig@gcc.gnu.org>:
https://gcc.gnu.org/g:862ea30fcb50735344f853e330ea58025fbe82d3
commit r10-8357-g862ea30fcb50735344f853e330ea58025fbe82d3
Author: Thomas Koenig <tkoenig@gcc.gnu.org>
Date: Tue Jun 23 21:59:47 2020 +0200
Make forall statement in testsuite conforming.
The recent patch for dependency checking introduced one failing test
case for pointer assignments in a forall statement. This test case
was invalid because of an interdependency in a forall statement.
This patch fixes that by removing that dependency.
gcc/testsuite/ChangeLog:
2020-06-23 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/95812
* gfortran.fortran-torture/execute/forall_5.f90: Make forall
statement conforming.
(cherry picked from commit 6f609029c7078fbd29e2f842074e2b99ea099096)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug fortran/95812] [10/11 Regression] ICE in gfc_dep_resolver since r10-2114
2020-06-22 8:38 [Bug fortran/95812] New: [10/11 Regression] ICE in gfc_dep_resolver since r10-2114 jakub at gcc dot gnu.org
` (10 preceding siblings ...)
2020-06-23 20:12 ` cvs-commit at gcc dot gnu.org
@ 2020-06-23 20:13 ` tkoenig at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2020-06-23 20:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95812
Thomas Koenig <tkoenig at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #10 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Fallout is now also fixed.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-06-23 20:13 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-22 8:38 [Bug fortran/95812] New: [10/11 Regression] ICE in gfc_dep_resolver since r10-2114 jakub at gcc dot gnu.org
2020-06-22 8:39 ` [Bug fortran/95812] " jakub at gcc dot gnu.org
2020-06-22 8:50 ` rguenth at gcc dot gnu.org
2020-06-22 9:38 ` tkoenig at gcc dot gnu.org
2020-06-22 22:35 ` tkoenig at gcc dot gnu.org
2020-06-23 6:15 ` cvs-commit at gcc dot gnu.org
2020-06-23 13:23 ` cvs-commit at gcc dot gnu.org
2020-06-23 13:23 ` tkoenig at gcc dot gnu.org
2020-06-23 16:47 ` dominiq at lps dot ens.fr
2020-06-23 17:33 ` tkoenig at gcc dot gnu.org
2020-06-23 20:01 ` tkoenig at gcc dot gnu.org
2020-06-23 20:12 ` cvs-commit at gcc dot gnu.org
2020-06-23 20:13 ` tkoenig at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).