public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tobi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/95859] [10/11 regression] Statically true asserts not recognized as such with -O2, but with -O1, -Og, -O3
Date: Fri, 02 Apr 2021 02:04:56 +0000 [thread overview]
Message-ID: <bug-95859-4-0GWJ9fmRRy@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-95859-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95859
--- Comment #11 from Tobias Schlüter <tobi at gcc dot gnu.org> ---
Works on trunk now but not 10.2. Compiler explorer link:
https://godbolt.org/z/1zbh4YM4W
On the trunk we get the following. I'm guessing that one could enhance the
read pattern by using more registers, but without benchmarking I don't believe
that this can be beat:
func34(m34):
pxor xmm0, xmm0
mov rax, rdi
cvtss2sd xmm0, DWORD PTR [rsp+8]
movsd QWORD PTR [rdi], xmm0
pxor xmm0, xmm0
cvtss2sd xmm0, DWORD PTR [rsp+24]
movsd QWORD PTR [rdi+8], xmm0
pxor xmm0, xmm0
cvtss2sd xmm0, DWORD PTR [rsp+40]
movsd QWORD PTR [rdi+16], xmm0
pxor xmm0, xmm0
cvtss2sd xmm0, DWORD PTR [rsp+12]
movsd QWORD PTR [rdi+24], xmm0
pxor xmm0, xmm0
cvtss2sd xmm0, DWORD PTR [rsp+28]
movsd QWORD PTR [rdi+32], xmm0
pxor xmm0, xmm0
cvtss2sd xmm0, DWORD PTR [rsp+44]
movsd QWORD PTR [rdi+40], xmm0
pxor xmm0, xmm0
cvtss2sd xmm0, DWORD PTR [rsp+16]
movsd QWORD PTR [rdi+48], xmm0
pxor xmm0, xmm0
cvtss2sd xmm0, DWORD PTR [rsp+32]
movsd QWORD PTR [rdi+56], xmm0
pxor xmm0, xmm0
cvtss2sd xmm0, DWORD PTR [rsp+48]
movsd QWORD PTR [rdi+64], xmm0
pxor xmm0, xmm0
cvtss2sd xmm0, DWORD PTR [rsp+20]
movsd QWORD PTR [rdi+72], xmm0
pxor xmm0, xmm0
cvtss2sd xmm0, DWORD PTR [rsp+36]
movsd QWORD PTR [rdi+80], xmm0
pxor xmm0, xmm0
cvtss2sd xmm0, DWORD PTR [rsp+52]
movsd QWORD PTR [rdi+88], xmm0
ret
Thanks to whoever did that.
I see that a release candidate for 10.2.1 has been cut. I would assume that
it's not fixed in 10.2.1 because there would be a bugfix mentioned here. My
experience is clearly not representative and I can appreciate that there was no
deluge of performance regression PRs, but I would think that Eigen is an
important enough library that one should consider whether breaking it like this
is really something that should survive several (sub-)releases.
next prev parent reply other threads:[~2021-04-02 2:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 7:28 [Bug rtl-optimization/95859] New: " tobi at gcc dot gnu.org
2020-06-24 7:51 ` [Bug ipa/95859] " rguenth at gcc dot gnu.org
2020-06-24 14:42 ` tobi at gcc dot gnu.org
2020-06-24 15:02 ` tobi at gcc dot gnu.org
2020-06-25 9:00 ` tobi at gcc dot gnu.org
2020-07-07 7:08 ` [Bug ipa/95859] [10/11 regression] " tobi at gcc dot gnu.org
2020-07-07 7:09 ` tobi at gcc dot gnu.org
2020-07-15 6:50 ` rguenth at gcc dot gnu.org
2020-07-23 6:51 ` rguenth at gcc dot gnu.org
2020-07-25 12:37 ` tobi at gcc dot gnu.org
2020-10-12 12:53 ` rguenth at gcc dot gnu.org
2021-02-25 11:08 ` jakub at gcc dot gnu.org
2021-03-10 20:04 ` jakub at gcc dot gnu.org
2021-04-02 2:04 ` tobi at gcc dot gnu.org [this message]
2021-04-02 2:07 ` tobi at gcc dot gnu.org
2021-04-05 2:35 ` tobi at gcc dot gnu.org
2021-04-08 12:02 ` rguenth at gcc dot gnu.org
2021-06-29 2:39 ` [Bug ipa/95859] [10/11/12 " tobi at gcc dot gnu.org
2021-09-05 17:54 ` pinskia at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-95859-4-0GWJ9fmRRy@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).