[Bug fortran/95881] New: [9/10/11 Regression] ICE in resolve_symbol, at fortran/resolve.c:15175

[Bug fortran/95881] New: [9/10/11 Regression] ICE in resolve_symbol, at fortran/resolve.c:15175

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95881

            Bug ID: 95881
           Summary: [9/10/11 Regression] ICE in resolve_symbol, at
                    fortran/resolve.c:15175
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Affects versions down to r7, with a missing attribute :


$ cat z1.f90
program p
   type t
      real, allocatable :: a[:]
   end type
   class(t) :: x
   allocate (x%a[*])
end


$ cat z2.f90
subroutine s(x)
   type t
      real, allocatable :: a[:]
   end type
   block
      class(t) :: x
      allocate (x%a[*])
   end block
end


$ gfortran-6 -c z1.f90 -fcoarray=lib
z1.f90:5:16:

    class(t) :: x
                1
Error: CLASS variable 'x' at (1) must be dummy, allocatable or pointer


$ gfortran-11-20200621 -c z1.f90 -fcoarray=single
z1.f90:5:16:

    5 |    class(t) :: x
      |                1
Error: CLASS variable 'x' at (1) must be dummy, allocatable or pointer


$ gfortran-11-20200621 -c z1.f90 -fcoarray=lib
f951: internal compiler error: Segmentation fault
0xbce57f crash_signal
        ../../gcc/toplev.c:328
0x6cda25 resolve_symbol
        ../../gcc/fortran/resolve.c:15175
0x6ebde2 do_traverse_symtree
        ../../gcc/fortran/symbol.c:4162
0x6d1094 resolve_types
        ../../gcc/fortran/resolve.c:17175
0x6cc7ac gfc_resolve(gfc_namespace*)
        ../../gcc/fortran/resolve.c:17290
0x6b48ec resolve_all_program_units
        ../../gcc/fortran/parse.c:6246
0x6b48ec gfc_parse_file()
        ../../gcc/fortran/parse.c:6493
0x70098f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:212

[Bug fortran/95881] [9/10/11 Regression] ICE in resolve_symbol, at fortran/resolve.c:15175 since r7-5348-g6479f45b31c13f30

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95881

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |vehre at gcc dot gnu.org
   Last reconfirmed|                            |2020-06-25
            Summary|[9/10/11 Regression] ICE in |[9/10/11 Regression] ICE in
                   |resolve_symbol, at          |resolve_symbol, at
                   |fortran/resolve.c:15175     |fortran/resolve.c:15175
                   |                            |since
                   |                            |r7-5348-g6479f45b31c13f30
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r7-5348-g6479f45b31c13f30.

[Bug fortran/95881] [9/10/11 Regression] ICE in resolve_symbol, at fortran/resolve.c:15175 since r7-5348-g6479f45b31c13f30

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95881

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |9.4
           Priority|P3                          |P4

[Bug fortran/95881] [9/10/11 Regression] ICE in resolve_symbol, at fortran/resolve.c:15175 since r7-5348-g6479f45b31c13f30

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95881

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #2 from anlauf at gcc dot gnu.org ---
With the patch:

diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c
index 6fa34caec54..55f57e2769b 100644
--- a/gcc/fortran/resolve.c
+++ b/gcc/fortran/resolve.c
@@ -15170,6 +15170,7 @@ resolve_symbol (gfc_symbol *sym)
   if (flag_coarray == GFC_FCOARRAY_LIB && sym->ts.type == BT_CLASS
       && sym->ts.u.derived && CLASS_DATA (sym)
       && CLASS_DATA (sym)->attr.codimension
+      && CLASS_DATA (sym)->ts.u.derived
       && (CLASS_DATA (sym)->ts.u.derived->attr.alloc_comp
          || CLASS_DATA (sym)->ts.u.derived->attr.pointer_comp))
     {

I get the error:

pr95881.f90:5:16:

    5 |    class(t) :: x
      |                1
Error: CLASS variable 'x' at (1) must be dummy, allocatable or pointer

[Bug fortran/95881] [9/10/11 Regression] ICE in resolve_symbol, at fortran/resolve.c:15175 since r7-5348-g6479f45b31c13f30

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95881

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org

--- Comment #3 from anlauf at gcc dot gnu.org ---
Patch: https://gcc.gnu.org/pipermail/fortran/2020-June/054633.html

[Bug fortran/95881] [9/10/11 Regression] ICE in resolve_symbol, at fortran/resolve.c:15175 since r7-5348-g6479f45b31c13f30

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95881

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:3cbc0fb39c84ae0a51a9a88649dccd105bf17d6e

commit r11-1688-g3cbc0fb39c84ae0a51a9a88649dccd105bf17d6e
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Sat Jun 27 14:56:33 2020 +0200

    PR fortran/95881 - ICE in resolve_symbol, at fortran/resolve.c:15175

    Avoid NULL pointer dereference.

    gcc/fortran/
            PR fortran/95881
            * resolve.c (resolve_symbol): Avoid NULL pointer dereference.

[Bug fortran/95881] [9/10/11 Regression] ICE in resolve_symbol, at fortran/resolve.c:15175 since r7-5348-g6479f45b31c13f30

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95881

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:d12079381e25571f2d5f7bb16eaef07ee89b361b

commit r10-8377-gd12079381e25571f2d5f7bb16eaef07ee89b361b
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Sat Jun 27 14:56:33 2020 +0200

    PR fortran/95881 - ICE in resolve_symbol, at fortran/resolve.c:15175

    Avoid NULL pointer dereference.

    gcc/fortran/
            PR fortran/95881
            * resolve.c (resolve_symbol): Avoid NULL pointer dereference.

    (cherry picked from commit 3cbc0fb39c84ae0a51a9a88649dccd105bf17d6e)

[Bug fortran/95881] [9/10/11 Regression] ICE in resolve_symbol, at fortran/resolve.c:15175 since r7-5348-g6479f45b31c13f30

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95881

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:cb797c730dd37ffe88ed0b1d04aec01982feacb5

commit r9-8703-gcb797c730dd37ffe88ed0b1d04aec01982feacb5
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Sat Jun 27 14:56:33 2020 +0200

    PR fortran/95881 - ICE in resolve_symbol, at fortran/resolve.c:15175

    Avoid NULL pointer dereference.

    gcc/fortran/
            PR fortran/95881
            * resolve.c (resolve_symbol): Avoid NULL pointer dereference.

    (cherry picked from commit 3cbc0fb39c84ae0a51a9a88649dccd105bf17d6e)

[Bug fortran/95881] [9/10/11 Regression] ICE in resolve_symbol, at fortran/resolve.c:15175 since r7-5348-g6479f45b31c13f30

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95881

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from anlauf at gcc dot gnu.org ---
FIXED on master for gcc-11, and on 10- and 9-branch.

Thanks for the report!