public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/95903] gcc 10: wrong code with -fwrapv
Date: Fri, 26 Jun 2020 08:56:45 +0000	[thread overview]
Message-ID: <bug-95903-4-3meI80kArl@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-95903-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95903

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 48788
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48788&action=edit
gcc11-pr95903.patch

Untested fix.  I don't really care what clang generates or what you find
expected on ilp32 targets, what matters is if what GCC generates is fast, and
unless somebody finds a wrong-code issue with that, it doesn't need to be
changed.
For the lp64 case, I can imagine a testcase, though it will be pretty rare in
practice and we need to slow down -fwrapv generated code because of that (isn't
e.g. Linux kernel built with -fwrapv?), just don't want to add it into the
testsuite as that would require allocating at least 4GB of memory.

On the other side, on:
extern char arr[];

char
baz (int off)
{
  off += 1;
  return arr[off];
}

char
qux (int off)
{
  return arr[off + 1];
}
we do generate the addition and then sign extension, and we should not, because
we would get better code otherwise.  arr[INT_MIN] is in this case certainly
invalid.  But that is about different code.

  parent reply	other threads:[~2020-06-26  8:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 23:25 [Bug middle-end/95903] New: " markus at oberhumer dot com
2020-06-26  6:30 ` [Bug middle-end/95903] " jakub at gcc dot gnu.org
2020-06-26  7:41 ` markus at oberhumer dot com
2020-06-26  8:05 ` jakub at gcc dot gnu.org
2020-06-26  8:35 ` markus at oberhumer dot com
2020-06-26  8:56 ` jakub at gcc dot gnu.org [this message]
2020-06-26 10:38 ` markus at oberhumer dot com
2020-06-26 11:03 ` jakub at gcc dot gnu.org
2020-06-26 11:17 ` markus at oberhumer dot com
2020-06-26 11:36 ` markus at oberhumer dot com
2020-06-27 10:42 ` cvs-commit at gcc dot gnu.org
2020-06-29  9:35 ` cvs-commit at gcc dot gnu.org
2020-09-16 19:22 ` cvs-commit at gcc dot gnu.org
2020-09-17 17:55 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-95903-4-3meI80kArl@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).