public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/95926] New: Failure to optimize xor pattern when
@ 2020-06-27  2:08 gabravier at gmail dot com
  2020-06-27 11:59 ` [Bug tree-optimization/95926] Failure to optimize xor pattern when using temporary variable glisse at gcc dot gnu.org
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: gabravier at gmail dot com @ 2020-06-27  2:08 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95926

            Bug ID: 95926
           Summary: Failure to optimize xor pattern when
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gabravier at gmail dot com
  Target Milestone: ---

bool f(bool a, bool b)
{
    bool tmp = a & b;
    return (tmp ^ b) | (tmp ^ a);
}

This code does not optimize as well as this code :

bool f(bool a, bool b)
{
    return ((a & b) ^ b) | ((a & b) ^ a);
}

which optimizes to `return a ^ b;`. This seems rather odd considering that they
are equivalent and the first example is just a simplification of the second
(i.e. made more readable).

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug tree-optimization/95926] Failure to optimize xor pattern when using temporary variable
  2020-06-27  2:08 [Bug tree-optimization/95926] New: Failure to optimize xor pattern when gabravier at gmail dot com
@ 2020-06-27 11:59 ` glisse at gcc dot gnu.org
  2020-06-29  9:45 ` rguenth at gcc dot gnu.org
  2021-08-15  0:07 ` pinskia at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: glisse at gcc dot gnu.org @ 2020-06-27 11:59 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95926

--- Comment #1 from Marc Glisse <glisse at gcc dot gnu.org> ---
It is different to gcc because in the first case, tmp is used twice, while in
the second case, each a&b is only used once, and gcc only transforms (a&b)^b to
b&~a if this is the only use of a&b. Yes, this heuristic often backfires, but
as long as we consider &~ as 2 operations, not restricting the transformation
could generate worse code in some cases.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug tree-optimization/95926] Failure to optimize xor pattern when using temporary variable
  2020-06-27  2:08 [Bug tree-optimization/95926] New: Failure to optimize xor pattern when gabravier at gmail dot com
  2020-06-27 11:59 ` [Bug tree-optimization/95926] Failure to optimize xor pattern when using temporary variable glisse at gcc dot gnu.org
@ 2020-06-29  9:45 ` rguenth at gcc dot gnu.org
  2021-08-15  0:07 ` pinskia at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-06-29  9:45 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95926

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2020-06-29
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Note :s tries to overcome this for "single" result operations like a ^ b
but single_use () checks make that stronger (and fail).

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug tree-optimization/95926] Failure to optimize xor pattern when using temporary variable
  2020-06-27  2:08 [Bug tree-optimization/95926] New: Failure to optimize xor pattern when gabravier at gmail dot com
  2020-06-27 11:59 ` [Bug tree-optimization/95926] Failure to optimize xor pattern when using temporary variable glisse at gcc dot gnu.org
  2020-06-29  9:45 ` rguenth at gcc dot gnu.org
@ 2021-08-15  0:07 ` pinskia at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-15  0:07 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95926

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2020-06-29 00:00:00         |2021-8-14
           Severity|normal                      |enhancement

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-15  0:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-27  2:08 [Bug tree-optimization/95926] New: Failure to optimize xor pattern when gabravier at gmail dot com
2020-06-27 11:59 ` [Bug tree-optimization/95926] Failure to optimize xor pattern when using temporary variable glisse at gcc dot gnu.org
2020-06-29  9:45 ` rguenth at gcc dot gnu.org
2021-08-15  0:07 ` pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).