public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "josephcsible at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/95941] New: Passing a struct by value wastes 16 bytes on the stack
Date: Sat, 27 Jun 2020 16:44:28 +0000	[thread overview]
Message-ID: <bug-95941-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95941

            Bug ID: 95941
           Summary: Passing a struct by value wastes 16 bytes on the stack
           Product: gcc
           Version: 10.1.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: josephcsible at gmail dot com
  Target Milestone: ---
            Target: x86_64-linux-gnu

Consider this C code:

extern struct foo {
    long x, y, z;
} s;

void f(struct foo);

void g(void) {
    f(s);
}

At "-O3", it compiles to this:

g:
        subq    $16, %rsp
        pushq   s+16(%rip)
        pushq   s+8(%rip)
        pushq   s(%rip)
        call    f
        addq    $40, %rsp
        ret

There's no reason at all to use that extra 16 bytes of stack space. It should
have compiled to this instead:

g:
        pushq   s+16(%rip)
        pushq   s+8(%rip)
        pushq   s(%rip)
        call    f
        addq    $24, %rsp
        ret

             reply	other threads:[~2020-06-27 16:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-27 16:44 josephcsible at gmail dot com [this message]
2020-06-29 10:36 ` [Bug target/95941] " rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-95941-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).