public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/95985] [11 Regression] ICE: tree check: expected tree_list,  have error_mark in common_handle_aligned_attribute, at c-family/c-attribs.c:1980
Date: Mon, 29 Jun 2020 19:28:38 +0000	[thread overview]
Message-ID: <bug-95985-4-DlbSFP0u1q@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-95985-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95985

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
           Keywords|                            |error-recovery

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
While we could do something like:
--- c-attribs.c.jj      2020-06-10 14:58:17.422495938 +0200
+++ c-attribs.c 2020-06-29 21:25:58.300888506 +0200
@@ -1975,7 +1975,9 @@ common_handle_aligned_attribute (tree *n
      yet.  */
   tree last_decl = node[1] ? node[1] : *node;

-  if (args)
+  if (args == error_mark_node)
+    align_expr = args;
+  else if (args)
     {
       align_expr = TREE_VALUE (args);
       if (align_expr && TREE_CODE (align_expr) != IDENTIFIER_NODE
I don't think it scales well, because we have hundreds of *handle_*attribute
functions and all of them assume that args is either NULL or a TREE_LIST and
changing them doesn't look right.

  parent reply	other threads:[~2020-06-29 19:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-29 18:47 [Bug c++/95985] New: " asolokha at gmx dot com
2020-06-29 19:21 ` [Bug c++/95985] " jakub at gcc dot gnu.org
2020-06-29 19:28 ` jakub at gcc dot gnu.org [this message]
2021-03-22  9:14 ` asolokha at gmx dot com
2021-04-27 11:39 ` [Bug c++/95985] [11/12 " jakub at gcc dot gnu.org
2021-07-28  7:04 ` rguenth at gcc dot gnu.org
2021-12-28 23:42 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-95985-4-DlbSFP0u1q@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).