public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "bergner at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/96017] Powerpc suboptimal register spill in likely path Date: Thu, 02 Jul 2020 01:18:45 +0000 [thread overview] Message-ID: <bug-96017-4-xisuphLVE4@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-96017-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96017 --- Comment #6 from Peter Bergner <bergner at gcc dot gnu.org> --- (In reply to Segher Boessenkool from comment #5) > But it is r31 already before > shrink-wrapping -- we need some renaming / copying of registers (like > in Peter's code) to get rid of it. In an example like this it is > quite useful, but in a lot of "real world" code there are no free > volatile registers to scarf up. Or that was my impression anyway, > when I last looked at this. Time to revisit it... Right, that's why we need to add the copies before RA, so we don't have to look for unused regs. But we don't want to add the copies too early just for the optimizer to remove them on us. Like it did for my manually added copies. There is ira.c:split_live_ranges_for_shrink_wrap(). I'll have a look to see why it's not catching this test case. > (The "ELFv1" code is just [snip] > which feels simpler... but it is kind of the same? It does look better, but marginally so, since we still stack a frame and save/restore r31 on the fast path.
next prev parent reply other threads:[~2020-07-02 1:18 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-01 9:57 [Bug target/96017] New: " npiggin at gmail dot com 2020-07-01 10:01 ` [Bug target/96017] " wschmidt at gcc dot gnu.org 2020-07-01 10:02 ` wschmidt at gcc dot gnu.org 2020-07-01 10:06 ` wschmidt at gcc dot gnu.org 2020-07-01 10:21 ` npiggin at gmail dot com 2020-07-01 14:00 ` bergner at gcc dot gnu.org 2020-07-01 23:58 ` segher at gcc dot gnu.org 2020-07-02 1:18 ` bergner at gcc dot gnu.org [this message] 2020-07-02 1:24 ` bergner at gcc dot gnu.org 2020-07-02 2:06 ` bergner at gcc dot gnu.org 2020-07-02 2:45 ` bergner at gcc dot gnu.org 2020-07-02 21:22 ` segher at gcc dot gnu.org 2020-07-02 21:24 ` segher at gcc dot gnu.org 2021-04-27 11:39 ` jakub at gcc dot gnu.org 2021-07-28 7:04 ` rguenth at gcc dot gnu.org 2023-11-24 8:46 ` jskumari at gcc dot gnu.org 2023-11-24 9:22 ` jskumari at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-96017-4-xisuphLVE4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).