public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "anlauf at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/96018] Optimization issue with external HDF5 library
Date: Wed, 01 Jul 2020 19:31:14 +0000	[thread overview]
Message-ID: <bug-96018-4-L8W53KX8Ik@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-96018-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96018

--- Comment #5 from anlauf at gcc dot gnu.org ---
(In reply to martin.schlipf from comment #4)
> Finally, I reproduced it with gfortran 9.3.0 + hdf 1.12.0 and gfortran 10.0
> + hdf 1.10.4. With older versions of gfortran 7.3.0 it does not appear.

Workarounds:

- compile with -O0, not sure why this makes a difference

- or replace in write_real_array_nd:

    real,             intent(in) :: array(*)

by

    real                         :: array(*)



I'd recommend to additionally replace in write_complex_array_3d

   ierr = write_real_array_4d(locid, dataset_name, ptr)

by

   ierr = write_real_array_4d(locid, dataset_name, &
                              reshape (transfer(array,[1.0]),[2,
shape(array)]))

The latter is IMO much cleaner Fortran.

There might by a bug in gfortran with the way you use c_f_pointer and
assumed-size, which generates wrong code for argument packing, or there
is a bug elsewhere which may corrupt data subtly.

  parent reply	other threads:[~2020-07-01 19:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 11:39 [Bug fortran/96018] New: " martin.schlipf at damnthespam dot com
2020-07-01 12:01 ` [Bug fortran/96018] " dominiq at lps dot ens.fr
2020-07-01 12:07 ` martin.schlipf at damnthespam dot com
2020-07-01 12:24 ` anlauf at gcc dot gnu.org
2020-07-01 13:03 ` martin.schlipf at damnthespam dot com
2020-07-01 19:31 ` anlauf at gcc dot gnu.org [this message]
2020-07-02  6:49 ` martin.schlipf at damnthespam dot com
2020-07-03  6:10 ` tkoenig at gcc dot gnu.org
2020-07-05 17:54 ` tkoenig at gcc dot gnu.org
2020-07-06 11:39 ` martin.schlipf at damnthespam dot com
2020-07-06 13:31 ` [Bug fortran/96018] [9/10/11 Regression] " dominiq at lps dot ens.fr
2020-07-06 14:24 ` rguenth at gcc dot gnu.org
2020-07-06 15:01 ` tkoenig at gcc dot gnu.org
2020-07-06 15:17 ` tkoenig at gcc dot gnu.org
2020-07-09 20:52 ` tkoenig at gcc dot gnu.org
2020-07-12  9:34 ` tkoenig at gcc dot gnu.org
2020-07-19 11:00 ` cvs-commit at gcc dot gnu.org
2020-07-23 15:56 ` cvs-commit at gcc dot gnu.org
2020-07-23 18:27 ` cvs-commit at gcc dot gnu.org
2020-07-23 18:28 ` tkoenig at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-96018-4-L8W53KX8Ik@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).