public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "nathan at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/96045] [11 Regression] Wrong line and column diagnostic message in a class template instantiation
Date: Tue, 22 Dec 2020 21:00:31 +0000	[thread overview]
Message-ID: <bug-96045-4-BuPAgzeL4V@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-96045-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96045

Nathan Sidwell <nathan at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |nathan at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #4 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
There's two conflicting arguments.
a) the end of the file is just after the last \n  (the preprocessor makes sure
the file ends in \n).  That's the first column of a line that doesn't exist.

b) the EOF is just before the last \n (at the \n itself if you like).

IIRC cpplib was taking both positions, and leading to inconsistencies.  My
intent was #a, as that's the more logical position of being after the \n.  But
it may not be the best choice.  We do have to do some rewinding to deal with
that non-existent line #a creates.

  parent reply	other threads:[~2020-12-22 21:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03 11:05 [Bug c++/96045] New: " haoxintu at gmail dot com
2020-07-08 21:54 ` [Bug c++/96045] [11 Regression] " mpolacek at gcc dot gnu.org
2020-07-08 21:57 ` mpolacek at gcc dot gnu.org
2020-10-16 11:54 ` rguenth at gcc dot gnu.org
2020-12-22 20:49 ` jason at gcc dot gnu.org
2020-12-22 21:00 ` nathan at gcc dot gnu.org [this message]
2020-12-23 22:26 ` cvs-commit at gcc dot gnu.org
2020-12-26 19:51 ` cvs-commit at gcc dot gnu.org
2021-01-28 16:07 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-96045-4-BuPAgzeL4V@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).