public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/96106] [10/11 Regression] A friend abbreviated template function denies access to private members
Date: Tue, 11 Aug 2020 13:37:59 +0000	[thread overview]
Message-ID: <bug-96106-4-M4AmKemzsU@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-96106-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96106

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:745ba1024c653324f9f0b88968c6f8989ed1e093

commit r10-8604-g745ba1024c653324f9f0b88968c6f8989ed1e093
Author: Patrick Palka <ppalka@redhat.com>
Date:   Wed Jul 29 22:06:36 2020 -0400

    c++: abbreviated function template friend matching [PR96106]

    In the below testcase, duplicate_decls wasn't merging the tsubsted
    friend declaration for 'void add(auto)' with its definition, because
    reduce_template_parm_level (during tsubst_friend_function) lost the
    DECL_VIRTUAL_P flag on the auto's invented template parameter, which
    caused template_heads_equivalent_p to deem the two template heads as not
    equivalent in C++20 mode.

    This patch makes reduce_template_parm_level carry over the
    DECL_VIRTUAL_P flag from the original TEMPLATE_PARM_DECL.

    gcc/cp/ChangeLog:

            PR c++/96106
            * pt.c (reduce_template_parm_level): Propagate DECL_VIRTUAL_P
            from the original TEMPLATE_PARM_DECL to the new lowered one.

    gcc/testsuite/ChangeLog:

            PR c++/96106
            * g++.dg/concepts/abbrev7.C: New test.

    (cherry picked from commit f31dd9beb95f4beda1d2bd5c0526c42d0ce455c4)

  parent reply	other threads:[~2020-08-11 13:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08  6:57 [Bug c++/96106] New: " kirshamir at gmail dot com
2020-07-08  7:21 ` [Bug c++/96106] [10/11 Regression] " redi at gcc dot gnu.org
2020-07-15  6:55 ` rguenth at gcc dot gnu.org
2020-07-16 13:45 ` ppalka at gcc dot gnu.org
2020-07-23  6:52 ` rguenth at gcc dot gnu.org
2020-07-30  2:15 ` cvs-commit at gcc dot gnu.org
2020-08-11 13:37 ` cvs-commit at gcc dot gnu.org [this message]
2020-08-11 13:39 ` ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-96106-4-M4AmKemzsU@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).