From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id DAE1438708D5; Fri, 29 Jan 2021 04:30:14 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DAE1438708D5
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/96137] [11 Regression] GCC hang on in invalid function
 definition
Date: Fri, 29 Jan 2021 04:30:14 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: compile-time-hog
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: mpolacek at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 11.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-96137-4-ksIPPXpLHL@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-96137-4@http.gcc.gnu.org/bugzilla/>
References: <bug-96137-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jan 2021 04:30:15 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D96137

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:

https://gcc.gnu.org/g:f8f5388c9e94d4324c31d82b335fa138518e3171

commit r11-6967-gf8f5388c9e94d4324c31d82b335fa138518e3171
Author: Marek Polacek <polacek@redhat.com>
Date:   Thu Jan 28 22:18:32 2021 -0500

    c++: Fix infinite looping with invalid operator [PR96137]

    My r11-86 adjusted cp_parser_class_name to do

    -  scope =3D parser->scope;
    +  scope =3D parser->scope ? parser->scope : parser->context->object_ty=
pe;
       if (scope =3D=3D error_mark_node)
         return error_mark_node;

    but that caused endless looping in cp_parser_type_specifier_seq (the
    while (true) loop) in this invalid test, because we never set a parser
    error, therefore cp_parser_type_specifier returned error_mark_node
    instead of NULL_TREE, and we never issued the "expected type-specifier"
    error.

    At first I thought I'd just add cp_parser_simulate_error right before
    the return, but that regresses crash81.C -- we'd emit multiple errors
    for "T::X".  So the next best thing seemed to revert to pre-r11-86
    behavior: return early when parser->scope is bad, otherwise proceed to
    get the parser error.

    gcc/cp/ChangeLog:

            PR c++/96137
            * parser.c (cp_parser_class_name): If parser->scope is
            error_mark_node, return it, otherwise continue.

    gcc/testsuite/ChangeLog:

            PR c++/96137
            * g++.dg/parse/error63.C: New test.=