From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 4147638708AF; Tue,  4 Aug 2020 15:05:10 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4147638708AF
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
 s=default; t=1596553510;
 bh=6JcVOXVmdPCDBufLg4rAXXK+7cI4F9QeFmWDuK1xA5c=;
 h=From:To:Subject:Date:In-Reply-To:References:From;
 b=n5aJbgcRe8+7ZDhfHO7FnFuizqJHmOVBe34ldBm3IbiHTJdtsjPzLBYPEEpkV8scP
 ob7Pd10rUtXwGHkpSnfKD2H+/U8Q1NRw4T0YYVHrhNen9CSsbP6lXrdD1MGnPOf9z2
 B4OhH/8/rIa0+isMFjgr85N0yImGqZq3xzNRHy2E=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug d/96153] d: struct literals have non-deterministic hash values
Date: Tue, 04 Aug 2020 15:05:10 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: d
X-Bugzilla-Version: 10.1.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ibuclaw at gdcproject dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-96153-4-WjAMASbpFt@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-96153-4@http.gcc.gnu.org/bugzilla/>
References: <bug-96153-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Aug 2020 15:05:10 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D96153

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:2ac51bdf63b0e17d1b9974f30303fb24e3cbc83d

commit r11-2548-g2ac51bdf63b0e17d1b9974f30303fb24e3cbc83d
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Wed Jul 22 09:50:38 2020 +0200

    d: Fix struct literals that have non-deterministic hash values (PR96153)

    Adds code generation for generating a temporary for, and pre-filling
    struct and array literals with zeroes before assigning, so that
    alignment holes don't cause objects to produce a non-deterministic hash
    value.  A new field has been added to the expression visitor to track
    whether the result is being generated for another literal, so that
    memset() is only called once on the top-level literal expression, and
    not for nesting struct or arrays.

    gcc/d/ChangeLog:

            PR d/96153
            * d-tree.h (build_expr): Add literalp argument.
            * expr.cc (ExprVisitor): Add literalp_ field.
            (ExprVisitor::ExprVisitor): Initialize literalp_.
            (ExprVisitor::visit (AssignExp *)): Call memset() on blits where
RHS
            is a struct literal.  Elide assignment if initializer is all
zeroes.
            (ExprVisitor::visit (CastExp *)): Forward literalp_ to generati=
on
of
            subexpression.
            (ExprVisitor::visit (AddrExp *)): Likewise.
            (ExprVisitor::visit (ArrayLiteralExp *)): Use memset() to pre-f=
ill
            object with zeroes.  Set literalp in subexpressions.
            (ExprVisitor::visit (StructLiteralExp *)): Likewise.
            (ExprVisitor::visit (TupleExp *)): Set literalp in subexpressio=
ns.
            (ExprVisitor::visit (VectorExp *)): Likewise.
            (ExprVisitor::visit (VectorArrayExp *)): Likewise.
            (build_expr): Forward literal_p to ExprVisitor.

    gcc/testsuite/ChangeLog:

            PR d/96153
            * gdc.dg/pr96153.d: New test.=