[Bug d/96157] New: d: No NRVO when returning an array of a non-POD struct

[Bug d/96157] New: d: No NRVO when returning an array of a non-POD struct

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96157

            Bug ID: 96157
           Summary: d: No NRVO when returning an array of a non-POD struct
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: d
          Assignee: ibuclaw at gdcproject dot org
          Reporter: ibuclaw at gdcproject dot org
  Target Milestone: ---

struct S
{
    @disable this(this); // triggers nrvo
    int v;
}

__gshared void* p;

S[1000] foo() nothrow
{
    typeof(return) d;
    p = &d;
    return d;
}

extern(C) void main() nothrow
{
    auto d = foo();
    assert(p == &d);
}

[Bug d/96157] d: No NRVO when returning an array of a non-POD struct

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96157

--- Comment #1 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
If I were to propagate TREE_ADDRESSABLE from S to the static array, then the
assert doesn't trigger.

However, there lots of breakages that occur elsewhere within the front-end, so
a little more extra handling needs to be done.

[Bug d/96157] d: No NRVO when returning an array of a non-POD struct

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96157

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:312ad889e99ff9458c01518325775e75ab57f272

commit r11-2863-g312ad889e99ff9458c01518325775e75ab57f272
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Tue Aug 25 00:39:17 2020 +0200

    d: Fix no NRVO when returning an array of a non-POD struct

    TREE_ADDRESSABLE was not propagated from the RECORD_TYPE to the ARRAY_TYPE,
so
    NRVO code generation was not being triggered.

    gcc/d/ChangeLog:

            PR d/96157
            * d-codegen.cc (d_build_call): Handle TREE_ADDRESSABLE static
arrays.
            * types.cc (make_array_type): Propagate TREE_ADDRESSABLE from base
            type to static array.

    gcc/testsuite/ChangeLog:

            PR d/96157
            * gdc.dg/pr96157a.d: New test.
            * gdc.dg/pr96157b.d: New test.

[Bug d/96157] d: No NRVO when returning an array of a non-POD struct

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96157

Iain Buclaw <ibuclaw at gdcproject dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
Done.

[Bug d/96157] d: No NRVO when returning an array of a non-POD struct

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96157

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Iain Buclaw
<ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:b30aeaa173b6886cda15570a2e23eac1136665bf

commit r10-8689-gb30aeaa173b6886cda15570a2e23eac1136665bf
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Tue Aug 25 00:39:17 2020 +0200

    d: Fix no NRVO when returning an array of a non-POD struct

    TREE_ADDRESSABLE was not propagated from the RECORD_TYPE to the ARRAY_TYPE,
so
    NRVO code generation was not being triggered.

    gcc/d/ChangeLog:

            PR d/96157
            * d-codegen.cc (d_build_call): Handle TREE_ADDRESSABLE static
arrays.
            * types.cc (make_array_type): Propagate TREE_ADDRESSABLE from base
            type to static array.

    gcc/testsuite/ChangeLog:

            PR d/96157
            * gdc.dg/pr96157a.d: New test.
            * gdc.dg/pr96157b.d: New test.

    (cherry picked from commit 312ad889e99ff9458c01518325775e75ab57f272)