public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "wilson at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/96191] New: aarch64 stack_protect_test canary leak Date: Tue, 14 Jul 2020 02:49:26 +0000 [thread overview] Message-ID: <bug-96191-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96191 Bug ID: 96191 Summary: aarch64 stack_protect_test canary leak Product: gcc Version: 11.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: target Assignee: unassigned at gcc dot gnu.org Reporter: wilson at gcc dot gnu.org Target Milestone: --- Given a simple testcase extern int sub (int); int main (void) { sub (10); return 0; } commpiling with -O -S -fstack-protector-all -mstack-protector-guard=global in the epilogue for the canary check I see ldr x1, [sp, 40] ldr x0, [x19, #:lo12:__stack_chk_guard] eor x0, x1, x0 cbnz x0, .L4 Both x0 and x1 have the stack protector canary loaded into them, and the eor clobbers x0, but x1 is left alone. This means the value of the canary is leaking from the epilogue. The canary value is never supposed to survive in a register outside the stack protector patterns. A powerpc64-linux toolchain build with the same testcase and options generates lwz 9,28(1) lwz 10,0(31) xor. 9,9,10 li 10,0 bne- 0,.L4 and note that it clears the second register after the xor to prevent the canary leak. The aarch64 stack_protect_test pattern should do the same thing.
next reply other threads:[~2020-07-14 2:49 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-14 2:49 wilson at gcc dot gnu.org [this message] 2020-07-14 8:22 ` [Bug target/96191] " rsandifo at gcc dot gnu.org 2020-07-14 18:58 ` wilco at gcc dot gnu.org 2020-07-14 22:30 ` wilson at gcc dot gnu.org 2020-08-05 14:19 ` cvs-commit at gcc dot gnu.org 2020-08-06 18:20 ` cvs-commit at gcc dot gnu.org 2020-08-07 11:15 ` cvs-commit at gcc dot gnu.org 2020-08-07 11:15 ` cvs-commit at gcc dot gnu.org 2020-08-07 11:18 ` cvs-commit at gcc dot gnu.org 2020-08-07 11:18 ` cvs-commit at gcc dot gnu.org 2020-11-17 18:17 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-96191-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).