public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/96194] [10/11 Regression] ICE in assign_temp, at function.c:984 during RTL pass: expand Date: Tue, 14 Jul 2020 14:03:09 +0000 [thread overview] Message-ID: <bug-96194-4-QV7v0tToUC@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-96194-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96194 --- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:b1d389d60d1929c7528ef984925ea010e3bf2c1a commit r11-2086-gb1d389d60d1929c7528ef984925ea010e3bf2c1a Author: Jakub Jelinek <jakub@redhat.com> Date: Tue Jul 14 16:01:11 2020 +0200 expr: Unbreak build of mesa [PR96194] > > The store to the whole of each volatile object was picked apart > > like there had been an individual assignment to each of the > > fields. Reads were added as part of that; see PR for details. > > The reads from volatile memory were a clear bug; individual > > stores questionable. A separate patch clarifies the docs. This breaks building of mesa on both the trunk and 10 branch. The problem is that the middle-end may never create temporaries of non-POD (TREE_ADDRESSABLE) types, those can be only created when the language says so and thus only the FE is allowed to create those. This patch just reverts the behavior to what we used to do before for the stores to volatile non-PODs. Perhaps we want to do something else, but definitely we can't create temporaries of the non-POD type. It is up to discussions on what should happen in those cases. 2020-07-14 Jakub Jelinek <jakub@redhat.com> PR middle-end/96194 * expr.c (expand_constructor): Don't create temporary for store to volatile MEM if exp has an addressable type. * g++.dg/opt/pr96194.C: New test.
next prev parent reply other threads:[~2020-07-14 14:03 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-14 8:12 [Bug c++/96194] New: 10.1.1: " manuel.lauss at googlemail dot com 2020-07-14 10:53 ` [Bug middle-end/96194] " jakub at gcc dot gnu.org 2020-07-14 11:02 ` [Bug middle-end/96194] [10/11 Regression] " jakub at gcc dot gnu.org 2020-07-14 11:09 ` jakub at gcc dot gnu.org 2020-07-14 11:10 ` jakub at gcc dot gnu.org 2020-07-14 11:22 ` jakub at gcc dot gnu.org 2020-07-14 12:03 ` manuel.lauss at googlemail dot com 2020-07-14 14:03 ` cvs-commit at gcc dot gnu.org [this message] 2020-07-14 14:04 ` cvs-commit at gcc dot gnu.org 2020-07-14 14:08 ` jakub at gcc dot gnu.org 2020-07-23 1:29 ` hp at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-96194-4-QV7v0tToUC@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).