public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/96203] [11 Regression] LTO bootstrap with --enable-cet is broken
Date: Fri, 17 Jul 2020 13:47:24 +0000	[thread overview]
Message-ID: <bug-96203-4-GIarAZXpXZ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-96203-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96203

--- Comment #16 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to rguenther@suse.de from comment #15)
> On Fri, 17 Jul 2020, hjl.tools at gmail dot com wrote:
> 
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96203
> > 
> > --- Comment #14 from H.J. Lu <hjl.tools at gmail dot com> ---
> > (In reply to Richard Biener from comment #13)
> > > (In reply to H.J. Lu from comment #12)
> > > > Please this patch.
> > > 
> > > /* Merge and update the -fcf-protection option.  */
> > > 
> > > but here you take the setting from the last file rather than merging it,
> > > I'd have expected a |= operation and also handling of CF_FULL for the
> > > string update.
> > 
> > The code has
> > 
> >            /* Merge and update the -fcf-protection option.  */
> > +           (*decoded_options)[j].value &= (foption->value
> > +                       & CF_FULL);
> > 
> > It must be "&=" not "|=" since CET features are enabled only if they are
> > enabled in ALL LTO inputs.
> 
> OK, so it mimics what the dynamic loader would do (and also the
> link editor?).

Yes.

  parent reply	other threads:[~2020-07-17 13:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15  7:21 [Bug bootstrap/96203] New: " rguenth at gcc dot gnu.org
2020-07-15  7:23 ` [Bug bootstrap/96203] " rguenth at gcc dot gnu.org
2020-07-15  7:28 ` cvs-commit at gcc dot gnu.org
2020-07-15  9:05 ` doko at debian dot org
2020-07-15  9:12 ` [Bug bootstrap/96203] [11 Regression] " rguenth at gcc dot gnu.org
2020-07-15 11:35 ` hjl.tools at gmail dot com
2020-07-15 11:40 ` hjl.tools at gmail dot com
2020-07-16  9:28 ` doko at debian dot org
2020-07-16 14:05 ` hjl.tools at gmail dot com
2020-07-16 14:28 ` doko at debian dot org
2020-07-16 14:32 ` hjl.tools at gmail dot com
2020-07-16 21:19 ` hjl.tools at gmail dot com
2020-07-16 21:20 ` hjl.tools at gmail dot com
2020-07-17  7:18 ` rguenth at gcc dot gnu.org
2020-07-17 12:37 ` hjl.tools at gmail dot com
2020-07-17 13:23 ` rguenther at suse dot de
2020-07-17 13:47 ` hjl.tools at gmail dot com [this message]
2020-07-27 11:43 ` cvs-commit at gcc dot gnu.org
2020-07-27 11:45 ` hjl.tools at gmail dot com
2020-09-11 10:21 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-96203-4-GIarAZXpXZ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).