public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/96238] New: [i386] cpuid.h header needs include guards
@ 2020-07-17 23:12 thiago at kde dot org
2020-07-18 11:55 ` [Bug target/96238] " hjl.tools at gmail dot com
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: thiago at kde dot org @ 2020-07-17 23:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96238
Bug ID: 96238
Summary: [i386] cpuid.h header needs include guards
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: thiago at kde dot org
Target Milestone: ---
$ cat x.c
#include <cpuid.h>
#include <cpuid.h>
$ gcc -c x.c
/usr/lib64/gcc/x86_64-suse-linux/10/include/cpuid.h:228:1: error: redefinition
of ‘__get_cpuid_max’
228 | __get_cpuid_max (unsigned int __ext, unsigned int *__sig)
| ^~~~~~~~~~~~~~~
In file included from <command-line>:32:
/usr/lib64/gcc/x86_64-suse-linux/10/include/cpuid.h:228:1: note: previous
definition of ‘__get_cpuid_max’ was here
228 | __get_cpuid_max (unsigned int __ext, unsigned int *__sig)
| ^~~~~~~~~~~~~~~
/usr/lib64/gcc/x86_64-suse-linux/10/include/cpuid.h:283:1: error: redefinition
of ‘__get_cpuid’
283 | __get_cpuid (unsigned int __leaf,
| ^~~~~~~~~~~
/usr/lib64/gcc/x86_64-suse-linux/10/include/cpuid.h:283:1: note: previous
definition of ‘__get_cpuid’ was here
283 | __get_cpuid (unsigned int __leaf,
| ^~~~~~~~~~~
/usr/lib64/gcc/x86_64-suse-linux/10/include/cpuid.h:300:1: error: redefinition
of ‘__get_cpuid_count’
300 | __get_cpuid_count (unsigned int __leaf, unsigned int __subleaf,
| ^~~~~~~~~~~~~~~~~
/usr/lib64/gcc/x86_64-suse-linux/10/include/cpuid.h:300:1: note: previous
definition of ‘__get_cpuid_count’ was here
300 | __get_cpuid_count (unsigned int __leaf, unsigned int __subleaf,
| ^~~~~~~~~~~~~~~~~
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/96238] [i386] cpuid.h header needs include guards
2020-07-17 23:12 [Bug target/96238] New: [i386] cpuid.h header needs include guards thiago at kde dot org
@ 2020-07-18 11:55 ` hjl.tools at gmail dot com
2020-07-19 11:21 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: hjl.tools at gmail dot com @ 2020-07-18 11:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96238
H.J. Lu <hjl.tools at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |https://gcc.gnu.org/piperma
| |il/gcc-patches/2020-July/55
| |0244.html
Version|unknown |11.0
Last reconfirmed| |2020-07-18
Keywords| |patch
Target Milestone|--- |11.0
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
A patch is posted at
https://gcc.gnu.org/pipermail/gcc-patches/2020-July/550244.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/96238] [i386] cpuid.h header needs include guards
2020-07-17 23:12 [Bug target/96238] New: [i386] cpuid.h header needs include guards thiago at kde dot org
2020-07-18 11:55 ` [Bug target/96238] " hjl.tools at gmail dot com
@ 2020-07-19 11:21 ` cvs-commit at gcc dot gnu.org
2020-07-19 12:26 ` hjl.tools at gmail dot com
2020-11-11 2:55 ` roland at gnu dot org
3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-07-19 11:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96238
--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:
https://gcc.gnu.org/g:29e1039ca211c4e3f1053925eda0a81c57cbcb0c
commit r11-2216-g29e1039ca211c4e3f1053925eda0a81c57cbcb0c
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Sat Jul 18 04:43:10 2020 -0700
x86: Add __cpuidex and include guard to <cpuid.h>
Add
void __cpuidex (int __cpuid_info[4], int __leaf, int __subleaf);
as well as include guard to <cpuid.h>.
gcc/
PR target/95973
PR target/96238
* config/i386/cpuid.h: Add include guard.
(__cpuidex): New.
gcc/testsuite/
PR target/95973
PR target/96238
* gcc.target/i386/pr95973.c: New test.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/96238] [i386] cpuid.h header needs include guards
2020-07-17 23:12 [Bug target/96238] New: [i386] cpuid.h header needs include guards thiago at kde dot org
2020-07-18 11:55 ` [Bug target/96238] " hjl.tools at gmail dot com
2020-07-19 11:21 ` cvs-commit at gcc dot gnu.org
@ 2020-07-19 12:26 ` hjl.tools at gmail dot com
2020-11-11 2:55 ` roland at gnu dot org
3 siblings, 0 replies; 5+ messages in thread
From: hjl.tools at gmail dot com @ 2020-07-19 12:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96238
H.J. Lu <hjl.tools at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for GCC 11.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/96238] [i386] cpuid.h header needs include guards
2020-07-17 23:12 [Bug target/96238] New: [i386] cpuid.h header needs include guards thiago at kde dot org
` (2 preceding siblings ...)
2020-07-19 12:26 ` hjl.tools at gmail dot com
@ 2020-11-11 2:55 ` roland at gnu dot org
3 siblings, 0 replies; 5+ messages in thread
From: roland at gnu dot org @ 2020-11-11 2:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96238
roland at gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |roland at gnu dot org
--- Comment #4 from roland at gnu dot org ---
Can at least the header guard fix be backported to 10?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-11 2:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 23:12 [Bug target/96238] New: [i386] cpuid.h header needs include guards thiago at kde dot org
2020-07-18 11:55 ` [Bug target/96238] " hjl.tools at gmail dot com
2020-07-19 11:21 ` cvs-commit at gcc dot gnu.org
2020-07-19 12:26 ` hjl.tools at gmail dot com
2020-11-11 2:55 ` roland at gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).