[Bug target/96262] New: [11 Regression] ICE: in decompose, at rtl.h:2280 with -O -mavx512bw

[Bug target/96262] New: [11 Regression] ICE: in decompose, at rtl.h:2280 with -O -mavx512bw

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96262

            Bug ID: 96262
           Summary: [11 Regression] ICE: in decompose, at rtl.h:2280 with
                    -O -mavx512bw
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Created attachment 48903
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48903&action=edit
reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-gcc -O -mavx512bw testcase.c 
during RTL pass: combine
testcase.c: In function 'foo':
testcase.c:7:1: internal compiler error: in decompose, at rtl.h:2280
    7 | }
      | ^
0x7267b9 wi::int_traits<std::pair<rtx_def*, machine_mode> >::decompose(long*,
unsigned int, std::pair<rtx_def*, machine_mode> const&)
        /repo/gcc-trunk/gcc/rtl.h:2280
0x7267b9 wide_int_ref_storage<false,
true>::wide_int_ref_storage<std::pair<rtx_def*, machine_mode>
>(std::pair<rtx_def*, machine_mode> const&)
        /repo/gcc-trunk/gcc/wide-int.h:1024
0x7267b9 generic_wide_int<wide_int_ref_storage<false, true>
>::generic_wide_int<std::pair<rtx_def*, machine_mode> >(std::pair<rtx_def*,
machine_mode> const&)
        /repo/gcc-trunk/gcc/wide-int.h:782
0x7267b9 simplify_const_unary_operation(rtx_code, machine_mode, rtx_def*,
machine_mode)
        /repo/gcc-trunk/gcc/simplify-rtx.c:1793
0x10ad410 simplify_unary_operation(rtx_code, machine_mode, rtx_def*,
machine_mode)
        /repo/gcc-trunk/gcc/simplify-rtx.c:868
0x10b0c6e simplify_const_unary_operation(rtx_code, machine_mode, rtx_def*,
machine_mode)
        /repo/gcc-trunk/gcc/simplify-rtx.c:1765
0x10ad410 simplify_unary_operation(rtx_code, machine_mode, rtx_def*,
machine_mode)
        /repo/gcc-trunk/gcc/simplify-rtx.c:868
0x1af73b5 combine_simplify_rtx
        /repo/gcc-trunk/gcc/combine.c:5785
0x1afa007 subst
        /repo/gcc-trunk/gcc/combine.c:5725
0x1afa16e subst
        /repo/gcc-trunk/gcc/combine.c:5658
0x1afa16e subst
        /repo/gcc-trunk/gcc/combine.c:5658
0x1afc126 try_combine
        /repo/gcc-trunk/gcc/combine.c:3451
0x1b04f14 combine_instructions
        /repo/gcc-trunk/gcc/combine.c:1324
0x1b04f14 rest_of_handle_combine
        /repo/gcc-trunk/gcc/combine.c:15068
0x1b04f14 execute
        /repo/gcc-trunk/gcc/combine.c:15113
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r11-2246-20200721142816-gc850a642e1d-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/11.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r11-2246-20200721142816-gc850a642e1d-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 11.0.0 20200721 (experimental) (GCC)

[Bug target/96262] [11 Regression] ICE: in decompose, at rtl.h:2280 with -O -mavx512bw

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96262

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0

[Bug target/96262] [11 Regression] ICE: in decompose, at rtl.h:2280 with -O -mavx512bw

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96262

Hongtao.liu <crazylht at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |crazylht at gmail dot com

--- Comment #1 from Hongtao.liu <crazylht at gmail dot com> ---
It's introduced by my patch.

[Bug target/96262] [11 Regression] ICE: in decompose, at rtl.h:2280 with -O -mavx512bw

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96262

--- Comment #2 from Hongtao.liu <crazylht at gmail dot com> ---
2268inline wi::storage_ref
2269wi::int_traits <rtx_mode_t>::decompose (HOST_WIDE_INT *,
2270                                        unsigned int precision,
2271                                        const rtx_mode_t &x)
2272{
2273  gcc_checking_assert (precision == get_precision (x));
2274  switch (GET_CODE (x.first))
2275    {
2276    case CONST_INT:
2277      if (precision < HOST_BITS_PER_WIDE_INT)
2278        /* Nonzero BImodes are stored as STORE_FLAG_VALUE, which on many
2279           targets is 1 rather than -1.  */
B228=>      gcc_checking_assert (INTVAL (x.first)
2281                             == sext_hwi (INTVAL (x.first), precision)
2282                             || (x.second == BImode && INTVAL (x.first) == 


(gdb) p debug_rtx (x.first)
(const_int 254 [0xfe])
(gdb) p INTVAL(x.first)
$48 = 254
(gdb) p sext_hwi (INTVAL (x.first), precision)
$49 = -2
(gdb) p precision
$50 = 8

For E_QImode const_int 254 is equivilent to -2, Should this condition be
relaxed?

Or it could be fixed by
---
-  unsigned int and_constant, xor_constant;
+  char and_constant, xor_constant; ---- > used by GEN_INT, be promoted to
HOST_WID_INT.
---

[Bug target/96262] [11 Regression] ICE: in decompose, at rtl.h:2280 with -O -mavx512bw since r11-1411-gc7199fb6e694d1a0

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96262

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2020-07-23
            Summary|[11 Regression] ICE: in     |[11 Regression] ICE: in
                   |decompose, at rtl.h:2280    |decompose, at rtl.h:2280
                   |with -O -mavx512bw          |with -O -mavx512bw since
                   |                            |r11-1411-gc7199fb6e694d1a0
             Status|UNCONFIRMED                 |ASSIGNED
                 CC|                            |marxin at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |crazylht at gmail dot com
     Ever confirmed|0                           |1

[Bug target/96262] [11 Regression] ICE: in decompose, at rtl.h:2280 with -O -mavx512bw since r11-1411-gc7199fb6e694d1a0

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96262

--- Comment #3 from Hongtao.liu <crazylht at gmail dot com> ---
a patch is posted at
https://gcc.gnu.org/pipermail/gcc-patches/2020-July/550427.html

[Bug target/96262] [11 Regression] ICE: in decompose, at rtl.h:2280 with -O -mavx512bw since r11-1411-gc7199fb6e694d1a0

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96262

--- Comment #4 from Zdenek Sojka <zsojka at seznam dot cz> ---
Created attachment 49080
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49080&action=edit
another testcase

[Bug target/96262] [11 Regression] ICE: in decompose, at rtl.h:2280 with -O -mavx512bw since r11-1411-gc7199fb6e694d1a0

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96262

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by hongtao Liu <liuhongt@gcc.gnu.org>:

https://gcc.gnu.org/g:c44c2a3b0559979e3694ee2ab6860ec95fa3068a

commit r11-2800-gc44c2a3b0559979e3694ee2ab6860ec95fa3068a
Author: liuhongt <hongtao.liu@intel.com>
Date:   Wed Jul 22 14:37:24 2020 +0800

    Using gen_int_mode instead of GEN_INT to avoid ICE caused by type
promotion.

    2020-07-22  Hongtao Liu  <hongtao.liu@intel.com>

    gcc/
            PR target/96262
            * config/i386/i386-expand.c
            (ix86_expand_vec_shift_qihi_constant): Refine.

    gcc/testsuite/
            * gcc.target/i386/pr96262-1.c: New test.

[Bug target/96262] [11 Regression] ICE: in decompose, at rtl.h:2280 with -O -mavx512bw since r11-1411-gc7199fb6e694d1a0

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96262

Hongtao.liu <crazylht at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from Hongtao.liu <crazylht at gmail dot com> ---
Fixed in GCC11.