public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/96264] [10/11 Regression] wrong code with -Os -fno-forward-propagate -fschedule-insns -fno-tree-ter
Date: Thu, 11 Feb 2021 15:49:00 +0000	[thread overview]
Message-ID: <bug-96264-4-zZuL9ZzZKf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-96264-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96264

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to seurer from comment #5)
> I too am able to duplicate this on a native powerpc64 LE machine.  Changing
> any of the compilation options (-Os -fno-forward-propagate -fschedule-insns
> -fno-tree-ter) generates code that works.
> 
> The revision that causes it is:
> 
> g:a7eb97ad269b6509bd7b31ca373daea98e4d7e85, r10-135
> 
> commit a7eb97ad269b6509bd7b31ca373daea98e4d7e85 (HEAD)
> Author: Richard Biener <rguenther@suse.de>
> Date:   Fri May 3 10:39:56 2019 +0000
> 
>     re PR middle-end/88963 (gcc generates terrible code for vectors of 64+
> length which are not natively supported)
>     
>     2019-05-03  Richard Biener  <rguenther@suse.de>
>     
>             PR tree-optimization/88963
>             * tree-ssa-forwprop.c (pass_forwprop::execute): Rewrite
>             vector loads feeding only BIT_FIELD_REFs to component
>             loads.  Rewrite stores fed by CONSTRUCTORs to component
>             stores.
>     
>             * gcc.dg/tree-ssa/ssa-fre-31.c: Disable forwprop.
>             * gcc.target/i386/pr88963-1.c: New testcase.
>             * gcc.target/i386/pr88963-2.c: Likewise.
>     
>     From-SVN: r270844
> 
> I compared the assembler output from r10-134 and r10-135 for the test case
> and the differences are significant.  Assembler output of the two revisions
> attached.

Note -fno-forward-propagate is an RTL optimization so if enabling that fixes
the issue the issue cannot really be the above rev. but it's probably exposed
by it only.  Note this is only done for vector load/stores using BLKmode.

Somebody needs to look at the RTL details to see what's the difference with
RTL fwprop or scheduling for example (at least for scheduling there are
existing dbg-counters that might help pointing to the breaking (non-)transform)

  parent reply	other threads:[~2021-02-11 15:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 11:00 [Bug rtl-optimization/96264] New: " zsojka at seznam dot cz
2020-07-21 14:20 ` [Bug rtl-optimization/96264] " rguenth at gcc dot gnu.org
2020-07-23  6:51 ` rguenth at gcc dot gnu.org
2020-07-23 10:56 ` marxin at gcc dot gnu.org
2020-10-12 12:44 ` rguenth at gcc dot gnu.org
2021-02-11 14:45 ` seurer at gcc dot gnu.org
2021-02-11 14:46 ` seurer at gcc dot gnu.org
2021-02-11 14:49 ` seurer at gcc dot gnu.org
2021-02-11 15:49 ` rguenth at gcc dot gnu.org [this message]
2021-02-11 16:00 ` jakub at gcc dot gnu.org
2021-02-11 16:19 ` seurer at gcc dot gnu.org
2021-02-11 18:43 ` jakub at gcc dot gnu.org
2021-02-11 19:01 ` jakub at gcc dot gnu.org
2021-02-17 15:47 ` vmakarov at gcc dot gnu.org
2021-02-18 22:51 ` cvs-commit at gcc dot gnu.org
2021-02-19 16:34 ` seurer at gcc dot gnu.org
2021-02-19 19:29 ` bergner at gcc dot gnu.org
2021-02-19 20:20 ` seurer at gcc dot gnu.org
2021-03-30 19:02 ` [Bug rtl-optimization/96264] [10 " bergner at gcc dot gnu.org
2021-03-30 21:33 ` vmakarov at gcc dot gnu.org
2021-03-31  7:16 ` rguenth at gcc dot gnu.org
2021-03-31 12:55 ` vmakarov at gcc dot gnu.org
2021-03-31 12:58 ` tnfchris at gcc dot gnu.org
2021-03-31 16:53 ` cvs-commit at gcc dot gnu.org
2021-03-31 16:57 ` vmakarov at gcc dot gnu.org
2021-03-31 20:01 ` seurer at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-96264-4-zZuL9ZzZKf@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).