public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/96271] Failure to optimize memcmp of doubles to avoid going through memory
Date: Sat, 16 Jan 2021 08:20:56 +0000 [thread overview]
Message-ID: <bug-96271-4-y76jJjvKuw@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-96271-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96271
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:b673e7547fb95d1f0d5cd17ae9e3874742cade66
commit r11-6747-gb673e7547fb95d1f0d5cd17ae9e3874742cade66
Author: Jakub Jelinek <jakub@redhat.com>
Date: Sat Jan 16 09:17:38 2021 +0100
cd_dce: Return TODO_update_address_taken from last cd_dce [PR96271]
On the following testcase, handle_builtin_memcmp in the strlen pass folds
the memcmp into comparison of two MEM_REFs. But nothing triggers updating
of addressable vars afterwards, so even when the parameters are no longer
address taken, we force the parameters to stack and back anyway.
This patch causes TODO_update_address_taken to happen right before last
forwprop
pass (at the end of last cd_dce), so after strlen1 too.
2021-01-16 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/96271
* passes.def: Pass false argument to first two pass_cd_dce
instances and true to last instance. Add comment that
last instance rewrites no longer addressed locals.
* tree-ssa-dce.c (pass_cd_dce): Add update_address_taken_p member
and
initialize it.
(pass_cd_dce::set_pass_param): New method.
(pass_cd_dce::execute): Return TODO_update_address_taken from
last cd_dce instance.
* gcc.target/i386/pr96271.c: New test.
next prev parent reply other threads:[~2021-01-16 8:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 16:41 [Bug tree-optimization/96271] New: " gabravier at gmail dot com
2020-07-21 18:49 ` [Bug target/96271] " pinskia at gcc dot gnu.org
2020-07-21 22:13 ` gabravier at gmail dot com
2020-07-22 7:23 ` crazylht at gmail dot com
2020-07-22 7:59 ` [Bug tree-optimization/96271] " rguenth at gcc dot gnu.org
2021-01-15 14:26 ` jakub at gcc dot gnu.org
2021-01-16 8:20 ` cvs-commit at gcc dot gnu.org [this message]
2021-01-16 8:26 ` jakub at gcc dot gnu.org
2021-01-16 8:43 ` jakub at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-96271-4-y76jJjvKuw@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).