public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/96282] [8/9 Regression] internal compiler error: in output_constructor_regular_field Date: Wed, 21 Apr 2021 21:09:42 +0000 [thread overview] Message-ID: <bug-96282-4-GON3cmwYHw@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-96282-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96282 --- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-9 branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>: https://gcc.gnu.org/g:fef6ee0790de58f16128a0de87571ba7e04b8320 commit r9-9455-gfef6ee0790de58f16128a0de87571ba7e04b8320 Author: Patrick Palka <ppalka@redhat.com> Date: Wed Aug 5 15:05:30 2020 -0400 c++: cxx_eval_vec_init after zero-initialization [PR96282] In the first testcase below, expand_aggr_init_1 sets up t's default constructor such that the ctor first zero-initializes the entire base b, followed by calling b's default constructor, the latter of which just default-initializes the array member b::m via a VEC_INIT_EXPR. So upon constexpr evaluation of this latter VEC_INIT_EXPR, ctx->ctor is nonempty due to the prior zero-initialization, and we proceed in cxx_eval_vec_init to append new constructor_elts to the end of ctx->ctor without first checking if a matching constructor_elt already exists. This leads to ctx->ctor having two matching constructor_elts for each index. This patch fixes this issue by truncating a zero-initialized array CONSTRUCTOR in cxx_eval_vec_init_1 before we begin appending array elements to it. We propagate its zeroed out state during evaluation by clearing CONSTRUCTOR_NO_CLEARING on each new appended aggregate element. gcc/cp/ChangeLog: PR c++/96282 * constexpr.c (cxx_eval_vec_init_1): Truncate ctx->ctor and then clear CONSTRUCTOR_NO_CLEARING on each appended element initializer if we're initializing a previously zero-initialized array object. gcc/testsuite/ChangeLog: PR c++/96282 * g++.dg/cpp0x/constexpr-array26.C: New test. * g++.dg/cpp0x/constexpr-array27.C: New test. Co-authored-by: Jason Merrill <jason@redhat.com> (cherry picked from commit d21252de6c81ed236d8981d47b9a57dc4f1c6d57)
next prev parent reply other threads:[~2021-04-21 21:09 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-22 12:13 [Bug c++/96282] New: " terra at gnome dot org 2020-07-22 12:14 ` [Bug c++/96282] " terra at gnome dot org 2020-07-22 14:13 ` [Bug c++/96282] [8/9/10/11 Regression] " rguenth at gcc dot gnu.org 2020-07-22 15:35 ` jakub at gcc dot gnu.org 2020-07-29 9:07 ` marxin at gcc dot gnu.org 2020-07-31 20:33 ` ppalka at gcc dot gnu.org 2020-08-05 19:08 ` cvs-commit at gcc dot gnu.org 2020-08-07 12:40 ` [Bug c++/96282] [8/9/10 " ppalka at gcc dot gnu.org 2021-02-01 13:41 ` cvs-commit at gcc dot gnu.org 2021-04-21 21:09 ` cvs-commit at gcc dot gnu.org [this message] 2021-05-14 14:01 ` [Bug c++/96282] [8 " jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-96282-4-GON3cmwYHw@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).