From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id EFA0C382E071; Mon,  1 Feb 2021 13:41:26 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EFA0C382E071
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/96282] [8/9/10 Regression] internal compiler error: in
 output_constructor_regular_field
Date: Mon, 01 Feb 2021 13:41:26 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 10.1.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: ppalka at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 8.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-96282-4-ztDskQErPE@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-96282-4@http.gcc.gnu.org/bugzilla/>
References: <bug-96282-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Feb 2021 13:41:27 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D96282

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:f426e4f63451e937c943606d3142b1ac6b70467a

commit r10-9331-gf426e4f63451e937c943606d3142b1ac6b70467a
Author: Patrick Palka <ppalka@redhat.com>
Date:   Wed Aug 5 15:05:30 2020 -0400

    c++: cxx_eval_vec_init after zero-initialization [PR96282]

    In the first testcase below, expand_aggr_init_1 sets up t's default
    constructor such that the ctor first zero-initializes the entire base b,
    followed by calling b's default constructor, the latter of which just
    default-initializes the array member b::m via a VEC_INIT_EXPR.

    So upon constexpr evaluation of this latter VEC_INIT_EXPR, ctx->ctor is
    nonempty due to the prior zero-initialization, and we proceed in
    cxx_eval_vec_init to append new constructor_elts to the end of ctx->ctor
    without first checking if a matching constructor_elt already exists.
    This leads to ctx->ctor having two matching constructor_elts for each
    index.

    This patch fixes this issue by truncating a zero-initialized array
    CONSTRUCTOR in cxx_eval_vec_init_1 before we begin appending array
    elements to it.  We propagate its zeroed out state during evaluation by
    clearing CONSTRUCTOR_NO_CLEARING on each new appended aggregate element.

    gcc/cp/ChangeLog:

            PR c++/96282
            * constexpr.c (cxx_eval_vec_init_1): Truncate ctx->ctor and
            then clear CONSTRUCTOR_NO_CLEARING on each appended element
            initializer if we're initializing a previously zero-initialized
            array object.

    gcc/testsuite/ChangeLog:

            PR c++/96282
            * g++.dg/cpp0x/constexpr-array26.C: New test.
            * g++.dg/cpp0x/constexpr-array27.C: New test.
            * g++.dg/cpp2a/constexpr-init18.C: New test.

    Co-authored-by: Jason Merrill <jason@redhat.com>
    (cherry picked from commit d21252de6c81ed236d8981d47b9a57dc4f1c6d57)=