public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/96322] New: 22_locale/numpunct/members/char/3.cc is outdated: expects grouping=0, actual=3
@ 2020-07-26 12:11 slyfox at gcc dot gnu.org
  2020-07-26 22:53 ` [Bug libstdc++/96322] " redi at gcc dot gnu.org
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: slyfox at gcc dot gnu.org @ 2020-07-26 12:11 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96322

            Bug ID: 96322
           Summary: 22_locale/numpunct/members/char/3.cc is outdated:
                    expects grouping=0, actual=3
           Product: gcc
           Version: 10.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: slyfox at gcc dot gnu.org
  Target Milestone: ---

Noticed as a test failure on glibc-2.31 system:

FAIL: 22_locale/numpunct/members/char/3.cc execution test

Test does
"""
  // nl_NL chosen because it has no thousands separator (at this time).
  locale loc_it = locale(ISO_8859(15,nl_NL));
  const numpunct<char>& nump_it = use_facet<numpunct<char> >(loc_it);
  string g = nump_it.grouping();
  // Ensure that grouping is empty for locales with empty thousands separator.
  VERIFY( g == "" );
"""
and expects "grouping 0;0".

The failure started after glibc-2.30 update which changed nl_NL locale
definition:

  -thousands_sep             ""
  -grouping                  0;0
  +thousands_sep             "."
  +grouping                  3;3

https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=fefa21790b5081e5d04662a240e2efd18603ef86

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libstdc++/96322] 22_locale/numpunct/members/char/3.cc is outdated: expects grouping=0, actual=3
  2020-07-26 12:11 [Bug libstdc++/96322] New: 22_locale/numpunct/members/char/3.cc is outdated: expects grouping=0, actual=3 slyfox at gcc dot gnu.org
@ 2020-07-26 22:53 ` redi at gcc dot gnu.org
  2020-11-12 23:45 ` slyfox at gcc dot gnu.org
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: redi at gcc dot gnu.org @ 2020-07-26 22:53 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96322

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2020-07-26
     Ever confirmed|0                           |1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libstdc++/96322] 22_locale/numpunct/members/char/3.cc is outdated: expects grouping=0, actual=3
  2020-07-26 12:11 [Bug libstdc++/96322] New: 22_locale/numpunct/members/char/3.cc is outdated: expects grouping=0, actual=3 slyfox at gcc dot gnu.org
  2020-07-26 22:53 ` [Bug libstdc++/96322] " redi at gcc dot gnu.org
@ 2020-11-12 23:45 ` slyfox at gcc dot gnu.org
  2020-11-13  0:29 ` redi at gcc dot gnu.org
  2020-11-13 21:42 ` slyfox at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: slyfox at gcc dot gnu.org @ 2020-11-12 23:45 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96322

--- Comment #1 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
Maybe pick another similar locale? Candidates are:

glibc $ git grep '0;0' localedata/locales/ | cat
localedata/locales/aa_DJ:grouping               0;0
localedata/locales/bs_BA:grouping                  0;0
localedata/locales/el_CY:grouping                  0;0
localedata/locales/el_GR:grouping                  0;0
localedata/locales/eo:grouping      0;0
localedata/locales/es_CU:grouping             0;0
localedata/locales/gl_ES:grouping             0;0
localedata/locales/mg_MG:grouping                  0;0
localedata/locales/pap_AW:grouping                  0;0
localedata/locales/pap_CW:grouping                  0;0
localedata/locales/pt_PT:grouping                  0;0
localedata/locales/sl_SI:grouping                  0;0
localedata/locales/sr_RS:grouping                  0;0
localedata/locales/ti_ER:grouping              0;0
localedata/locales/wo_SN:grouping                  0;0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libstdc++/96322] 22_locale/numpunct/members/char/3.cc is outdated: expects grouping=0, actual=3
  2020-07-26 12:11 [Bug libstdc++/96322] New: 22_locale/numpunct/members/char/3.cc is outdated: expects grouping=0, actual=3 slyfox at gcc dot gnu.org
  2020-07-26 22:53 ` [Bug libstdc++/96322] " redi at gcc dot gnu.org
  2020-11-12 23:45 ` slyfox at gcc dot gnu.org
@ 2020-11-13  0:29 ` redi at gcc dot gnu.org
  2020-11-13 21:42 ` slyfox at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: redi at gcc dot gnu.org @ 2020-11-13  0:29 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96322

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
We really need to create our own custom locales for testing, so that we don't
depend on externally defined data that keep changing.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug libstdc++/96322] 22_locale/numpunct/members/char/3.cc is outdated: expects grouping=0, actual=3
  2020-07-26 12:11 [Bug libstdc++/96322] New: 22_locale/numpunct/members/char/3.cc is outdated: expects grouping=0, actual=3 slyfox at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2020-11-13  0:29 ` redi at gcc dot gnu.org
@ 2020-11-13 21:42 ` slyfox at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: slyfox at gcc dot gnu.org @ 2020-11-13 21:42 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96322

--- Comment #3 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
Good point.

I tried pt_PT on FreeBSD to check if it's the same as in Linux and it's not:
there grouping=3 is used. +1 for custom locale.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-11-13 21:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-26 12:11 [Bug libstdc++/96322] New: 22_locale/numpunct/members/char/3.cc is outdated: expects grouping=0, actual=3 slyfox at gcc dot gnu.org
2020-07-26 22:53 ` [Bug libstdc++/96322] " redi at gcc dot gnu.org
2020-11-12 23:45 ` slyfox at gcc dot gnu.org
2020-11-13  0:29 ` redi at gcc dot gnu.org
2020-11-13 21:42 ` slyfox at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).