From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 1DA38393C86E; Mon, 26 Oct 2020 16:20:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1DA38393C86E From: "rsandifo at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/96342] [SVE] Add support for "omp declare simd" Date: Mon, 26 Oct 2020 16:20:32 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 11.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: rsandifo at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 16:20:33 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D96342 --- Comment #6 from rsandifo at gcc dot gnu.org --- Comment on attachment 49413 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=3D49413 part1-patch Thanks for the summary and patches, and sorry for the delayed reply. Taking part1-patch first: this generally looks good to me. Some minor things: - It isn't necessary to use poly_int stuff in i386.c, since the new poly_uint64 will naturally decay to a uint64_t in i386 target files. It might still be necessary to update some of the printf formats though. - It's more correct to use "unsigned HOST_WIDE_INT" instead of "long unsigned int" and %wd instead of %ld. One reason is that we support cross builds from 32-bit hosts, where long is 32 bits. Long is also 32 bits for ILP32. - Some of the multiple_p calls can instead use exact_div, which is the preferred way of performing a division that is known to have no remainder. I think it's clear that we need to make this change, and since it's a natural "poly_intification", I don't think it needs to wait for other SVE work to be completed. So would you be able to submit the patch to the list independently of the other work? Stage 1 closes in three weeks' time so it would be good to get this in before then. Thanks again for doing this.=