public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug preprocessor/96391] [10 Regression] ICE in linemap_compare_locations on "CONST VOID" in large C++ files
Date: Wed, 16 Jun 2021 18:33:50 +0000	[thread overview]
Message-ID: <bug-96391-4-kCKBrTcxsH@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-96391-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96391

--- Comment #26 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jason Merrill
<jason@gcc.gnu.org>:

https://gcc.gnu.org/g:bb2e908638758097e261bca1a4825d171a18af9c

commit r11-8583-gbb2e908638758097e261bca1a4825d171a18af9c
Author: Jason Merrill <jason@redhat.com>
Date:   Mon Jun 14 17:37:43 2021 -0400

    libcpp: location comparison within macro [PR100796]

    The patch for 96391 changed linemap_compare_locations to give up on
    comparing locations from macro expansions if we don't have column
    information.  But in this testcase, the BOILERPLATE macro is multiple lines
    long, so we do want to compare locations within the macro.  So this patch
    moves the LINE_MAP_MAX_LOCATION_WITH_COLS check inside the block, to use it
    for failing gracefully.

            PR c++/100796
            PR preprocessor/96391

    libcpp/ChangeLog:

            * line-map.c (linemap_compare_locations): Only use comparison with
            LINE_MAP_MAX_LOCATION_WITH_COLS to avoid abort.

    gcc/testsuite/ChangeLog:

            * g++.dg/plugin/location-overflow-test-pr100796.c: New test.
            * g++.dg/plugin/plugin.exp: Run it.

  parent reply	other threads:[~2021-06-16 18:33 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30 15:51 [Bug c++/96391] New: internal compiler error: in linemap_compare_locations, at libcpp/line-map.c:1359 mike at cchtml dot com
2020-07-30 15:52 ` [Bug c++/96391] " mike at cchtml dot com
2020-07-31  6:15 ` [Bug preprocessor/96391] [10/11 Regression] " rguenth at gcc dot gnu.org
2020-07-31  6:18 ` marxin at gcc dot gnu.org
2020-07-31 18:13 ` mike at cchtml dot com
2020-09-04 17:50 ` jan.smets at nokia dot com
2020-10-07 19:46 ` qinzhao at gcc dot gnu.org
2020-10-09 16:48 ` qinzhao at gcc dot gnu.org
2020-10-09 16:49 ` qinzhao at gcc dot gnu.org
2020-12-06  3:18 ` mike at cchtml dot com
2021-02-09  0:10 ` dmalcolm at gcc dot gnu.org
2021-02-09  7:06 ` jan.smets at nokia dot com
2021-02-09 14:40 ` dmalcolm at gcc dot gnu.org
2021-02-10  0:04 ` mike at cchtml dot com
2021-02-10 11:42 ` dmalcolm at gcc dot gnu.org
2021-02-10 12:15 ` dmalcolm at gcc dot gnu.org
2021-02-10 15:05 ` dmalcolm at gcc dot gnu.org
2021-02-10 15:57 ` rguenther at suse dot de
2021-02-10 16:08 ` qinzhao at gcc dot gnu.org
2021-02-10 16:57 ` dmalcolm at gcc dot gnu.org
2021-02-10 16:58 ` dmalcolm at gcc dot gnu.org
2021-02-10 19:33 ` [Bug preprocessor/96391] [10/11 Regression] ICE in linemap_compare_locations on "CONST VOID" in large C++ files cvs-commit at gcc dot gnu.org
2021-02-10 19:38 ` [Bug preprocessor/96391] [10 " dmalcolm at gcc dot gnu.org
2021-02-10 20:24 ` dmalcolm at gcc dot gnu.org
2021-02-10 23:32 ` qinzhao at gcc dot gnu.org
2021-04-08 12:02 ` rguenth at gcc dot gnu.org
2021-06-16 15:41 ` cvs-commit at gcc dot gnu.org
2021-06-16 18:33 ` cvs-commit at gcc dot gnu.org [this message]
2022-01-25 20:05 ` mike at cchtml dot com
2022-01-26  7:05 ` rguenth at gcc dot gnu.org
2022-06-28 10:41 ` jakub at gcc dot gnu.org
2023-07-07  8:59 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-96391-4-kCKBrTcxsH@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).