public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/96459] OpenMP host teams reductions ignored
Date: Wed, 05 Aug 2020 08:44:35 +0000	[thread overview]
Message-ID: <bug-96459-4-IiUolGMFsy@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-96459-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96459

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:916c7a201a9a1dc94f2c056a773826a26d1daca9

commit r11-2571-g916c7a201a9a1dc94f2c056a773826a26d1daca9
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Aug 5 10:40:10 2020 +0200

    openmp: Handle reduction clauses on host teams construct [PR96459]

    As the new testcase shows, we weren't actually performing reductions on
    host teams construct.  And fixing that revealed a flaw in the for-14.c
testcase.
    The problem is that the tests perform also initialization and checking
around the
    calls to the functions with the OpenMP constructs.  In that testcase, all
the
    tests have been spawned from a teams construct but only the tested loops
were
    distribute, which means the initialization and checking has been performed
    redundantly and racily in each team.  Fixed by performing the
initialization
    and checking outside of host teams and only do the calls to functions with
    the tested constructs inside of host teams.

    2020-08-05  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/96459
            * omp-low.c (lower_omp_taskreg): Call lower_reduction_clauses even
in
            for host teams.

            * testsuite/libgomp.c/teams-3.c: New test.
            * testsuite/libgomp.c-c++-common/for-2.h (OMPTEAMS): Define to
nothing
            if not defined yet.
            (N(test)): Use it before all N(f*) calls.
            * testsuite/libgomp.c-c++-common/for-14.c (DO_PRAGMA, OMPTEAMS):
Define.
            (main): Don't call all test_* functions from within
            #pragma omp teams reduction(|:err), call them directly.

  parent reply	other threads:[~2020-08-05  8:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04 14:47 [Bug middle-end/96459] New: " jakub at gcc dot gnu.org
2020-08-04 14:49 ` [Bug middle-end/96459] " jakub at gcc dot gnu.org
2020-08-04 14:57 ` jakub at gcc dot gnu.org
2020-08-04 14:59 ` jakub at gcc dot gnu.org
2020-08-05  8:44 ` cvs-commit at gcc dot gnu.org [this message]
2020-08-25 17:44 ` cvs-commit at gcc dot gnu.org
2020-09-16 19:22 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-96459-4-IiUolGMFsy@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).