public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/96482] [10/11 Regression] Combination of -finline-small-functions and ipa-cp optimisations causes incorrect values being passed to a function since r279523
Date: Tue, 11 Aug 2020 07:59:58 +0000	[thread overview]
Message-ID: <bug-96482-4-TF3BopkY4t@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-96482-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96482

--- Comment #10 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #9)
> Also this one shows the problem: -fdbg-cnt=ipa_cp_bits:10460-10461.
> 
> If I see correctly the function body:
> lto-dump -dump-body=addr_to_index nir_lower_io.c.o
> Gimple Body of Function: addr_to_index
> addr_to_index (struct nir_builder * b, struct nir_ssa_def * addr,
> nir_address_format addr_format)
> {
>   unsigned int c;
> 
>   <bb 2> [local count: 1073741824]:
>   if (addr_format_3(D) == 3)
>     goto <bb 3>; [20.24%]
>   else
>     goto <bb 4>; [79.76%]
> 
>   <bb 3> [local count: 217325344]:
>   c = 0;
>   _9 = nir_swizzle (b_5(D), addr_6(D), &c, 1);
>   c ={v} {CLOBBER};
>   goto <bb 7>; [100.00%]
> 
>   <bb 4> [local count: 856416481]:
>   if (addr_format_3(D) == 4)
>     goto <bb 5>; [100.00%]
>   else
>     goto <bb 6>; [0.00%]
> 
>   <bb 5> [local count: 856416481]:
>   _8 = nir_channels (b_5(D), addr_6(D), 3);
>   goto <bb 7>; [100.00%]
> 
>   <bb 6> [count: 0]:
>   __builtin_unreachable ();
> 
>   <bb 7> [local count: 1073741824]:
>   # _1 = PHI <_9(3), _8(5)>
>   return _1;
> 
> }
> 
> addr_format (aka param 2) is either 3 or 4.
> 3 = 0x011
> 4 = 0x100
> 
> so mask 6 = 0x110 is wrong as first bit is not constant.
> @Martin: Am I right?

^^^
@Martin ?

  parent reply	other threads:[~2020-08-11  7:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05 11:24 [Bug c/96482] New: Combination of -finline-small-functions and ipa-cp optimisations causes incorrect values being passed to a function yevh.kolesnikov at gmail dot com
2020-08-05 11:27 ` [Bug c/96482] " yevh.kolesnikov at gmail dot com
2020-08-05 11:37 ` [Bug ipa/96482] [10/11 Regression] " rguenth at gcc dot gnu.org
2020-08-10  7:29 ` [Bug ipa/96482] [10/11 Regression] Combination of -finline-small-functions and ipa-cp optimisations causes incorrect values being passed to a function since r279523 marxin at gcc dot gnu.org
2020-08-10  7:41 ` hubicka at gcc dot gnu.org
2020-08-10 14:24 ` yevh.kolesnikov at gmail dot com
2020-08-10 16:58 ` yevh.kolesnikov at gmail dot com
2020-08-10 20:00 ` marxin at gcc dot gnu.org
2020-08-11  7:08 ` marxin at gcc dot gnu.org
2020-08-11  7:59 ` marxin at gcc dot gnu.org
2020-08-11  7:59 ` marxin at gcc dot gnu.org [this message]
2020-08-11  8:02 ` marxin at gcc dot gnu.org
2020-08-11  9:39 ` marxin at gcc dot gnu.org
2020-08-11 15:12 ` marxin at gcc dot gnu.org
2020-08-11 15:33 ` marxin at gcc dot gnu.org
2020-08-11 15:51 ` marxin at gcc dot gnu.org
2020-08-11 16:09 ` marxin at gcc dot gnu.org
2020-08-12  7:38 ` marxin at gcc dot gnu.org
2020-08-12 17:06 ` cvs-commit at gcc dot gnu.org
2020-08-12 17:07 ` [Bug ipa/96482] [10 " marxin at gcc dot gnu.org
2020-08-12 17:40 ` cvs-commit at gcc dot gnu.org
2020-08-12 17:41 ` marxin at gcc dot gnu.org
2020-08-13  8:27 ` cvs-commit at gcc dot gnu.org
2020-08-13 14:12 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-96482-4-TF3BopkY4t@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).