public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/96482] [10 Regression] Combination of -finline-small-functions and ipa-cp optimisations causes incorrect values being passed to a function since r279523
Date: Wed, 12 Aug 2020 17:40:28 +0000	[thread overview]
Message-ID: <bug-96482-4-qgIgEeJvAR@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-96482-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96482

--- Comment #20 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Martin Liska
<marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:66780083a0e79e5cb7c3acc8665aa47be4084a67

commit r10-8614-g66780083a0e79e5cb7c3acc8665aa47be4084a67
Author: Martin Liska <mliska@suse.cz>
Date:   Wed Aug 12 09:21:51 2020 +0200

    ipa: fix bit CPP when combined with IPA bit CP

    As mentioned in the PR, let's consider the following example:

    int
    __attribute__((noinline))
    foo(int arg)
    {
      if (arg == 3)
        return 1;
      if (arg == 4)
        return 123;

      __builtin_unreachable ();
    }

    during WPA we find all calls of the function
    (yes the call with value 5 is UBSAN):

      Node: foo/0:
        param [0]: 5 [loc_time: 4, loc_size: 2, prop_time: 0, prop_size: 0]
                   3 [loc_time: 3, loc_size: 3, prop_time: 0, prop_size: 0]
             ctxs: VARIABLE
             Bits: value = 0x5, mask = 0x6

    in LTRANS we have the following VRP info:

      # RANGE [3, 3] NONZERO 3

    when we AND masks in get_default_value we end up with 6 & 3 = 2 (0x010).
    That means the only second (least significant bit) is unknown and
    value (5 = 0x101) & ~mask gives us either 7 (0x111) or 5 (0x101).

    That's why if (arg_2(D) == 3) gets optimized to false.

    gcc/ChangeLog:

            PR ipa/96482
            * ipa-cp.c (ipcp_bits_lattice::meet_with_1): Drop value bits
            for bits that are unknown.
            (ipcp_bits_lattice::set_to_constant): Likewise.
            * tree-ssa-ccp.c (get_default_value): Add sanity check that
            IPA CP bit info has all bits set to zero in bits that
            are unknown.

    gcc/testsuite/ChangeLog:

            PR ipa/96482
            * gcc.dg/ipa/pr96482.c: New test.

    (cherry picked from commit d58f078ce2d53e5dab6b3d0d5f960504268e1894)

  parent reply	other threads:[~2020-08-12 17:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05 11:24 [Bug c/96482] New: Combination of -finline-small-functions and ipa-cp optimisations causes incorrect values being passed to a function yevh.kolesnikov at gmail dot com
2020-08-05 11:27 ` [Bug c/96482] " yevh.kolesnikov at gmail dot com
2020-08-05 11:37 ` [Bug ipa/96482] [10/11 Regression] " rguenth at gcc dot gnu.org
2020-08-10  7:29 ` [Bug ipa/96482] [10/11 Regression] Combination of -finline-small-functions and ipa-cp optimisations causes incorrect values being passed to a function since r279523 marxin at gcc dot gnu.org
2020-08-10  7:41 ` hubicka at gcc dot gnu.org
2020-08-10 14:24 ` yevh.kolesnikov at gmail dot com
2020-08-10 16:58 ` yevh.kolesnikov at gmail dot com
2020-08-10 20:00 ` marxin at gcc dot gnu.org
2020-08-11  7:08 ` marxin at gcc dot gnu.org
2020-08-11  7:59 ` marxin at gcc dot gnu.org
2020-08-11  7:59 ` marxin at gcc dot gnu.org
2020-08-11  8:02 ` marxin at gcc dot gnu.org
2020-08-11  9:39 ` marxin at gcc dot gnu.org
2020-08-11 15:12 ` marxin at gcc dot gnu.org
2020-08-11 15:33 ` marxin at gcc dot gnu.org
2020-08-11 15:51 ` marxin at gcc dot gnu.org
2020-08-11 16:09 ` marxin at gcc dot gnu.org
2020-08-12  7:38 ` marxin at gcc dot gnu.org
2020-08-12 17:06 ` cvs-commit at gcc dot gnu.org
2020-08-12 17:07 ` [Bug ipa/96482] [10 " marxin at gcc dot gnu.org
2020-08-12 17:40 ` cvs-commit at gcc dot gnu.org [this message]
2020-08-12 17:41 ` marxin at gcc dot gnu.org
2020-08-13  8:27 ` cvs-commit at gcc dot gnu.org
2020-08-13 14:12 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-96482-4-qgIgEeJvAR@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).