[Bug testsuite/96525] New: new test gcc.target/powerpc/pr96493.c fails

[Bug testsuite/96525] New: new test gcc.target/powerpc/pr96493.c fails

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96525

            Bug ID: 96525
           Summary: new test gcc.target/powerpc/pr96493.c fails
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:f8ac30f1653ff69706c35af6d725f1d330600f11, r11-2603 

This was on a power 8:

Executing on host: /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.target/powerpc/pr96493.c   
-fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers
-fdiagnostics-color=never  -fdiagnostics-urls=never   -mdejagnu-cpu=power8 -O2 
-lm  -o ./pr96493.exe    (timeout = 300)
spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.target/powerpc/pr96493.c
-fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers
-fdiagnostics-color=never -fdiagnostics-urls=never -mdejagnu-cpu=power8 -O2 -lm
-o ./pr96493.exe
/tmp/ccrh64Cq.s: Assembler messages:
/tmp/ccrh64Cq.s:33: Error: invalid machine `power10'
compiler exited with status 1
Executing on host: /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/ exceptions_enabled1054367.cc   
-fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers
-fdiagnostics-color=never  -fdiagnostics-urls=never  -S -o
exceptions_enabled1054367.s    (timeout = 300)
spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/ exceptions_enabled1054367.cc
-fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers
-fdiagnostics-color=never -fdiagnostics-urls=never -S -o
exceptions_enabled1054367.s
FAIL: gcc.target/powerpc/pr96493.c (test for excess errors)
Excess errors:
/tmp/ccrh64Cq.s:33: Error: invalid machine `power10'

UNRESOLVED: gcc.target/powerpc/pr96493.c compilation failed to produce
executable

[Bug testsuite/96525] new test gcc.target/powerpc/pr96493.c fails

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96525

--- Comment #1 from Peter Bergner <bergner at gcc dot gnu.org> ---
This is an assembler error saying it doesn't know about .machine "power10". 
Are you sure you're not using an old binutils?

[Bug testsuite/96525] new test gcc.target/powerpc/pr96493.c fails

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96525

--- Comment #2 from Peter Bergner <bergner at gcc dot gnu.org> ---
Ah, you probably are and this issue is the test case probably needs a:

/* { dg-require-effective-target power10_ok } */

To ensure we have a working power10 enabled binutils.

[Bug testsuite/96525] new test gcc.target/powerpc/pr96493.c fails

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96525

--- Comment #3 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Peter Bergner from comment #2)
> Ah, you probably are and this issue is the test case probably needs a:
> 
> /* { dg-require-effective-target power10_ok } */
> 
> To ensure we have a working power10 enabled binutils.

Actually, this is a dg-do run test case, so we need:

/* { dg-require-effective-target power10_hw } */

[Bug testsuite/96525] new test gcc.target/powerpc/pr96493.c fails

[amodra at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96525

Alan Modra <amodra at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2020-08-10
           Assignee|unassigned at gcc dot gnu.org      |amodra at gmail dot com
                 CC|amodra at gcc dot gnu.org          |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1

--- Comment #4 from Alan Modra <amodra at gmail dot com> ---
Yes, the test needs power10_ok, but *not* power10_hw.  Despite being a "run"
test with one function cpu=power10, no power10 insns are generated.  So the
executable could in fact be run (even on a power3).

If you make the test power10_hw, then it won't be linked unless of course you
have power10 hardware or a simulator.  Most people don't.   We really do want
to at least link the compiler output as it is the link stage that shows up the
pr96493 problem.

I could make the test { do-do link } but running the test is just that little
bit better test of the linker output, and as far as I know there isn't a way of
saying "link this but only run on power10".

[Bug testsuite/96525] new test gcc.target/powerpc/pr96493.c fails

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96525

--- Comment #5 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Alan Modra from comment #4)
> I could make the test { do-do link } but running the test is just that
> little bit better test of the linker output, and as far as I know there
> isn't a way of saying "link this but only run on power10".

Does this work?

-/* { dg-do run } */
+/* { dg-do run { target power10_hw } } */
+/* { dg-do link { target { ! power10_hw } } } */
 /* { dg-options "-mdejagnu-cpu=power8 -O2" } */
 /* { dg-require-effective-target powerpc_elfv2 } */
+/* { dg-require-effective-target power10_ok } */

[Bug testsuite/96525] new test gcc.target/powerpc/pr96493.c fails

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96525

--- Comment #6 from seurer at gcc dot gnu.org ---
That changed the test to unsupported on the p8 where it had failed previously.

Executing on host: /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/ power10_hw_available2538527.c   
-fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers
-fdiagnostics-color=never  -fdiagnostics-urls=never  -mcpu=power10  -lm  -o
power10_hw_available2538527.exe    (timeout = 300)
spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/ power10_hw_available2538527.c
-fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers
-fdiagnostics-color=never -fdiagnostics-urls=never -mcpu=power10 -lm -o
power10_hw_available2538527.exe
Assembler messages:
Error: invalid switch -mpower10
Error: unrecognized option -mpower10
compiler exited with status 1
Executing on host: /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/    -fno-diagnostics-show-caret
-fno-diagnostics-show-line-numbers -fdiagnostics-color=never 
-fdiagnostics-urls=never  -c -o powerpc_elfv22538527.o powerpc_elfv22538527.c  
 (timeout = 300)
spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/ -fno-diagnostics-show-caret
-fno-diagnostics-show-line-numbers -fdiagnostics-color=never
-fdiagnostics-urls=never -c -o powerpc_elfv22538527.o powerpc_elfv22538527.c
Executing on host: /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/    -fno-diagnostics-show-caret
-fno-diagnostics-show-line-numbers -fdiagnostics-color=never 
-fdiagnostics-urls=never  -mcpu=power10 -c -o power10_ok2538527.o
power10_ok2538527.c    (timeout = 300)
spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/ -fno-diagnostics-show-caret
-fno-diagnostics-show-line-numbers -fdiagnostics-color=never
-fdiagnostics-urls=never -mcpu=power10 -c -o power10_ok2538527.o
power10_ok2538527.c
Assembler messages:
Error: invalid switch -mpower10
Error: unrecognized option -mpower10
compiler exited with status 1
UNSUPPORTED: gcc.target/powerpc/pr96493.c

. . .

                === gcc Summary ===

# of unsupported tests          1

[Bug testsuite/96525] new test gcc.target/powerpc/pr96493.c fails

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96525

--- Comment #7 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to seurer from comment #6)
> That changed the test to unsupported on the p8 where it had failed
> previously.
[snip]
> # of unsupported tests		1

That is what I would expect on a system with an old binutils.  Do you have a
testsuite run that has a newer power10 enabled binutils?  Then hopefully, you
should see a PASS of the dg-do link command.

[Bug testsuite/96525] new test gcc.target/powerpc/pr96493.c fails

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96525

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alan Modra <amodra@gcc.gnu.org>:

https://gcc.gnu.org/g:2ba0674c657fb2089d8aae4f8c254ce0559c8f53

commit r11-2660-g2ba0674c657fb2089d8aae4f8c254ce0559c8f53
Author: Alan Modra <amodra@gmail.com>
Date:   Mon Aug 10 23:01:12 2020 +0930

    Re: PR96493, powerpc local call linkage failure

            PR target/96525
            * gcc.target/powerpc/pr96493.c: Make it a link test when no
            power10_hw.  Require power10_ok.

[Bug testsuite/96525] new test gcc.target/powerpc/pr96493.c fails

[amodra at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96525

Alan Modra <amodra at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #9 from Alan Modra <amodra at gmail dot com> ---
Fixed

[Bug testsuite/96525] new test gcc.target/powerpc/pr96493.c fails

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96525

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Alan Modra <amodra@gcc.gnu.org>:

https://gcc.gnu.org/g:c99b2c529befc24bdd0cd6ca20ff8c99f70628ae

commit r10-8616-gc99b2c529befc24bdd0cd6ca20ff8c99f70628ae
Author: Alan Modra <amodra@gmail.com>
Date:   Mon Aug 10 23:01:12 2020 +0930

    Re: PR96493, powerpc local call linkage failure

            PR target/96525
            * gcc.target/powerpc/pr96493.c: Make it a link test when no
            power10_hw.  Require power10_ok.

    (cherry picked from commit 2ba0674c657fb2089d8aae4f8c254ce0559c8f53)