[Bug target/96530] New: MMA built-ins reject typedefs of MMA types

[Bug target/96530] New: MMA built-ins reject typedefs of MMA types

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96530

            Bug ID: 96530
           Summary: MMA built-ins reject typedefs of MMA types
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: bergner at gcc dot gnu.org
  Target Milestone: ---

We need to accept typedefs of MMA types too:

typedef __vector_quad vquad_t;

void
foo (__vector_quad *dst)
{
  __builtin_mma_xxsetaccz (dst);
}

void
bar (vquad_t *dst)
{
  __builtin_mma_xxsetaccz (dst);
}

bergner@pike:~/gcc/BUGS$ gcc -S -O2 -mcpu=power10 bug.c 
bug.c: In function ‘bar’:
bug.c:12:3: error: invalid conversion from type ‘* __vector_quad’
   12 |   __builtin_mma_xxsetaccz (dst);
      |   ^~~~~~~~~~~~~~~~~~~~~~~

[Bug target/96530] MMA built-ins reject typedefs of MMA types

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96530

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |powerpc*-*-*
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2020-08-07
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |bergner at gcc dot gnu.org
                 CC|                            |dje at gcc dot gnu.org,
                   |                            |segher at gcc dot gnu.org,
                   |                            |wschmidt at gcc dot gnu.org
           Keywords|                            |rejects-valid

--- Comment #1 from Peter Bergner <bergner at gcc dot gnu.org> ---
Confirmed and mine.

[Bug target/96530] MMA built-ins reject typedefs of MMA types

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96530

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Peter Bergner <bergner@gcc.gnu.org>:

https://gcc.gnu.org/g:e2882e76089cecdc268d0835c54cabfa80b5b0be

commit r11-2616-ge2882e76089cecdc268d0835c54cabfa80b5b0be
Author: Peter Bergner <bergner@linux.ibm.com>
Date:   Sat Aug 8 11:54:48 2020 -0500

    rs6000: MMA built-ins reject typedefs of MMA types

    We do not allow conversions between the MMA types and other types.
    However, we are being too strict in not matching MMA types with
    typdefs of those types.  Use TYPE_CANONICAL to see through the
    types to their canonical types before comparing them.

    2020-08-08  Peter Bergner  <bergner@linux.ibm.com>

    gcc/
            PR target/96530
            * config/rs6000/rs6000.c (rs6000_invalid_conversion): Use canonical
            types for type comparisons.  Refactor code to simplify it.

    gcc/testsuite/
            PR target/96530
            * gcc.target/powerpc/pr96530.c: New test.

[Bug target/96530] MMA built-ins reject typedefs of MMA types

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96530

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.3

--- Comment #3 from Peter Bergner <bergner at gcc dot gnu.org> ---
Fixed on trunk.  Will let it bake a little before backporting to GCC 10.

[Bug target/96530] MMA built-ins reject typedefs of MMA types

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96530

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Peter Bergner
<bergner@gcc.gnu.org>:

https://gcc.gnu.org/g:a8c8ff7712d2cce5d7f26224160d8422b87babfc

commit r10-8597-ga8c8ff7712d2cce5d7f26224160d8422b87babfc
Author: Peter Bergner <bergner@linux.ibm.com>
Date:   Sat Aug 8 11:54:48 2020 -0500

    rs6000: MMA built-ins reject typedefs of MMA types

    We do not allow conversions between the MMA types and other types.
    However, we are being too strict in not matching MMA types with
    typdefs of those types.  Use TYPE_CANONICAL to see through the
    types to their canonical types before comparing them.

    2020-08-08  Peter Bergner  <bergner@linux.ibm.com>

    gcc/
            PR target/96530
            * config/rs6000/rs6000.c (rs6000_invalid_conversion): Use canonical
            types for type comparisons.  Refactor code to simplify it.

    gcc/testsuite/
            PR target/96530
            * gcc.target/powerpc/pr96530.c: New test.

    (cherry picked from commit e2882e76089cecdc268d0835c54cabfa80b5b0be)

[Bug target/96530] MMA built-ins reject typedefs of MMA types

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96530

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Peter Bergner <bergner at gcc dot gnu.org> ---
Fixed everywhere.