public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "nathan at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/96633] New: missed optimization?
Date: Sun, 16 Aug 2020 21:25:44 +0000	[thread overview]
Message-ID: <bug-96633-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96633

            Bug ID: 96633
           Summary: missed optimization?
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: nathan at gcc dot gnu.org
  Target Milestone: ---

Matt Godbolt's https://queue.acm.org/detail.cfm?id=3372264
has an example of optimizing on amd64:

bool isWhitespace(char c)
 {
     return c == ' '
       || c == '\r'
       || c == '\n'
       || c == '\t';
 }

GCC generates: 
        xorl    %eax, %eax
        cmpb    $32, %dil
        ja      .L1
        movabsq $4294977024, %rax
        movl    %edi, %ecx
        shrq    %cl, %rax
        andl    $1, %eax
.L1:
        ret

following an amazing comment on the ML, I've determined the following is abot
12% faster (and shorter too):

        movabsq $4294977024, %rax
        movl   %edi, %ecx
        shrq    %cl, %rax
        shr    $6, %ecx
        andl    $1, %eax
        shrq    %cl, %rax
        ret

We're dealing with chars in the range [-128,128), and x86's shift operator only
considers the bottom 6 bits.

             reply	other threads:[~2020-08-16 21:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-16 21:25 nathan at gcc dot gnu.org [this message]
2020-08-17  8:14 ` [Bug tree-optimization/96633] " marxin at gcc dot gnu.org
2020-08-17 12:07 ` amonakov at gcc dot gnu.org
2020-08-20 11:36 ` marxin at gcc dot gnu.org
2021-07-21  1:05 ` [Bug middle-end/96633] " pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-96633-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).