[Bug analyzer/96640] New: [11 Regression] ICE in on_assignment, at analyzer/region-model.cc:561 (sorry, unimplemented: unhandled assignment op)

[Bug analyzer/96640] New: [11 Regression] ICE in on_assignment, at analyzer/region-model.cc:561 (sorry, unimplemented: unhandled assignment op)

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96640

            Bug ID: 96640
           Summary: [11 Regression] ICE in on_assignment, at
                    analyzer/region-model.cc:561 (sorry, unimplemented:
                    unhandled assignment op)
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: analyzer
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---
            Target: powerpc-*-linux-gnu

gcc-11.0.0-alpha20200816 snapshot (g:c99116aeeb9644ebddec653ee8b19de4d38b65bd)
ICEs when compiling the following testcase w/ -mvsx -fanalyzer:

void
x4 (void)
{
  __attribute__ ((altivec (vector__))) short int xy, nk;
  __builtin_vec_sra (__builtin_vec_mule (xy, nk),
                    (__attribute__ ((altivec (vector__))) unsigned int) {});
}

% powerpc-e300c3-linux-gnu-gcc-11.0.0 -mvsx -fanalyzer -c yhkjopg3.c
yhkjopg3.c: In function 'x4':
yhkjopg3.c:6:21: sorry, unimplemented: unhandled assignment op:
'widen_mult_even_expr'
    6 |                     (__attribute__ ((altivec (vector__))) unsigned int)
{});
      |                     ^
during IPA pass: analyzer
yhkjopg3.c:6:21: internal compiler error: in on_assignment, at
analyzer/region-model.cc:561
0x113b50e ana::region_model::on_assignment(gassign const*,
ana::region_model_context*)
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-11.0.0_alpha20200816/work/gcc-11-20200816/gcc/analyzer/region-model.cc:561
0x111ed2a ana::exploded_node::on_stmt(ana::exploded_graph&, ana::supernode
const*, gimple const*, ana::program_state*) const
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-11.0.0_alpha20200816/work/gcc-11-20200816/gcc/analyzer/engine.cc:1029
0x111ff65 ana::exploded_graph::process_node(ana::exploded_node*)
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-11.0.0_alpha20200816/work/gcc-11-20200816/gcc/analyzer/engine.cc:2526
0x11207c2 ana::exploded_graph::process_worklist()
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-11.0.0_alpha20200816/work/gcc-11-20200816/gcc/analyzer/engine.cc:2341
0x11228a4 ana::impl_run_checkers(ana::logger*)
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-11.0.0_alpha20200816/work/gcc-11-20200816/gcc/analyzer/engine.cc:4107
0x1123551 ana::run_checkers()
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-11.0.0_alpha20200816/work/gcc-11-20200816/gcc/analyzer/engine.cc:4175
0x1118128 execute
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-11.0.0_alpha20200816/work/gcc-11-20200816/gcc/analyzer/analyzer-pass.cc:84

I also see other unhandled ops when compiling other testcases, these are
bit_insert_expr, cond_expr, and paren_expr.

I do recognize that this ICE results from a technical limitation in the
analyzer code and is not a bug per se.

[Bug analyzer/96640] [11 Regression] ICE in on_assignment, at analyzer/region-model.cc:561 (sorry, unimplemented: unhandled assignment op)

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96640

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2020-08-17
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1

--- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Thanks; confirmed.  Working on a fix.

[Bug analyzer/96640] [11 Regression] ICE in on_assignment, at analyzer/region-model.cc:561 (sorry, unimplemented: unhandled assignment op)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96640

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:1b0be822208349b2795381deace2352e998c1ad0

commit r11-2728-g1b0be822208349b2795381deace2352e998c1ad0
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Mon Aug 17 11:53:45 2020 -0400

    analyzer: fix ICE on unhandled tree codes in gassign [PR96640]

    PR analyzer/96640 reports a ICE within region_model::on_assignment when
    failing to handle a WIDEN_MULT_EVEN_EXPR, and various other tree codes.

    The old implementation of region_model::on_assignment gracefully handled
    tree codes it didn't understand, returning "UNKNOWN", whereas the new
    implementation (r11-2694-g808f4dfeb3a95f50f15e71148e5c1067f90a126d) had
    a "sorry_at" and an assertion left over from development, leading to ICEs.

    This patch restores the old behavior for these cases, and marks various
    vector operations as leading to unknown results.

    gcc/analyzer/ChangeLog:
            PR analyzer/96640
            * region-model.cc (region_model::get_gassign_result): Handle
various
            VEC_* tree codes by returning UNKNOWN.
            (region_model::on_assignment): Handle unrecognized tree codes by
            setting lhs to an unknown value, rather than issuing a "sorry" and
            asserting.

[Bug analyzer/96640] [11 Regression] ICE in on_assignment, at analyzer/region-model.cc:561 (sorry, unimplemented: unhandled assignment op)

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96640

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Should be fixed by the above commit.