[Bug testsuite/96718] New: [11 regression] 25_algorithms/pstl/feature_test-3.cc has excess error after r11-2743

[Bug testsuite/96718] New: [11 regression] 25_algorithms/pstl/feature_test-3.cc has excess error after r11-2743

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96718

            Bug ID: 96718
           Summary: [11 regression] 25_algorithms/pstl/feature_test-3.cc
                    has excess error after r11-2743
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:d367f5fcb579d21c3093cf5c464f5787fe584a1d, r11-2743

Executing on host: /home/seurer/gcc/git/build/gcc-test/./gcc/xg++
-shared-libgcc -B/home/seurer/gcc/git/build/gcc-test/./gcc -nostdinc++
-L/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/src
-L/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/src/.libs
-L/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs
-B/home/seurer/gcc/git/install/gcc-test/powerpc64le-unknown-linux-gnu/bin/
-B/home/seurer/gcc/git/install/gcc-test/powerpc64le-unknown-linux-gnu/lib/
-isystem
/home/seurer/gcc/git/install/gcc-test/powerpc64le-unknown-linux-gnu/include
-isystem
/home/seurer/gcc/git/install/gcc-test/powerpc64le-unknown-linux-gnu/sys-include
-B/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/./libstdc++-v3/src/.libs
-fmessage-length=0 -fno-show-column -ffunction-sections -fdata-sections -g -O2
-D_GNU_SOURCE -DLOCALEDIR="." -nostdinc++
-I/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include/powerpc64le-unknown-linux-gnu
-I/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include
-I/home/seurer/gcc/git/gcc-test/libstdc++-v3/libsupc++
-I/home/seurer/gcc/git/gcc-test/libstdc++-v3/include/backward
-I/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/util
/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/25_algorithms/pstl/feature_test-3.cc
   -std=gnu++17 -fdiagnostics-plain-output -E -o feature_test-3.i    (timeout =
600)
spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-test/./gcc/xg++
-shared-libgcc -B/home/seurer/gcc/git/build/gcc-test/./gcc -nostdinc++
-L/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/src
-L/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/src/.libs
-L/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs
-B/home/seurer/gcc/git/install/gcc-test/powerpc64le-unknown-linux-gnu/bin/
-B/home/seurer/gcc/git/install/gcc-test/powerpc64le-unknown-linux-gnu/lib/
-isystem
/home/seurer/gcc/git/install/gcc-test/powerpc64le-unknown-linux-gnu/include
-isystem
/home/seurer/gcc/git/install/gcc-test/powerpc64le-unknown-linux-gnu/sys-include
-B/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/./libstdc++-v3/src/.libs
-fmessage-length=0 -fno-show-column -ffunction-sections -fdata-sections -g -O2
-D_GNU_SOURCE -DLOCALEDIR="." -nostdinc++
-I/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include/powerpc64le-unknown-linux-gnu
-I/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include
-I/home/seurer/gcc/git/gcc-test/libstdc++-v3/libsupc++
-I/home/seurer/gcc/git/gcc-test/libstdc++-v3/include/backward
-I/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/util
/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/25_algorithms/pstl/feature_test-3.cc
-std=gnu++17 -fdiagnostics-plain-output -E -o feature_test-3.i
In file included from
/home/seurer/gcc/git/gcc-test/libstdc++-v3/include/pstl/parallel_backend.h:16,
                 from
/home/seurer/gcc/git/gcc-test/libstdc++-v3/include/pstl/algorithm_impl.h:22,
                 from
/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include/pstl/glue_execution_defs.h:50,
                 from
/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include/execution:32,
                 from
/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/25_algorithms/pstl/feature_test-3.cc:21:
/home/seurer/gcc/git/gcc-test/libstdc++-v3/include/pstl/parallel_backend_tbb.h:28:
error: #error Intel(R) Threading Building Blocks 2018 is required; older
versions are not supported.
compiler exited with status 1
FAIL: 25_algorithms/pstl/feature_test-3.cc (test for excess errors)
Excess errors:
/home/seurer/gcc/git/gcc-test/libstdc++-v3/include/pstl/parallel_backend_tbb.h:28:
error: #error Intel(R) Threading Building Blocks 2018 is required; older
versions are not supported.

testcase
/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp
completed in 14 seconds

                === libstdc++ Summary ===

# of unexpected failures        1

[Bug testsuite/96718] [11 regression] 25_algorithms/pstl/feature_test-3.cc has excess error after r11-2743

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96718

seurer at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from seurer at gcc dot gnu.org ---
Sorry, git bisect lead me astray.  I will reopen once I narrow it down to the
actual failing revision.

[Bug testsuite/96718] 25_algorithms/pstl/feature_test-3.cc has excess error

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96718

seurer at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
            Summary|[11 regression]             |25_algorithms/pstl/feature_
                   |25_algorithms/pstl/feature_ |test-3.cc has excess error
                   |test-3.cc has excess error  |
                   |after r11-2743              |
         Resolution|INVALID                     |---
             Status|RESOLVED                    |REOPENED
   Last reconfirmed|                            |2020-08-20

--- Comment #2 from seurer at gcc dot gnu.org ---
Ignore the above mention of a specific revision.  This always fails for me even
going back to r11-1 on one (just the one) of my power 8 LE test machines.  I
thought it might be something to do with the older binutils 2.27 version on
that system but I tested with binutils 2.35 and it does the same thing.

Anyone know what might be going on?

[Bug testsuite/96718] 25_algorithms/pstl/feature_test-3.cc has excess error

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96718

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
             Status|REOPENED                    |ASSIGNED

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I forgot to add this to that test:

// { dg-require-effective-target tbb-backend }

[Bug libstdc++/96718] 25_algorithms/pstl/feature_test-3.cc has excess error

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96718

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.3

[Bug libstdc++/96718] 25_algorithms/pstl/feature_test-3.cc has excess error

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96718

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:988fb2f597d67cdf3603654372c020c28448441f

commit r11-2797-g988fb2f597d67cdf3603654372c020c28448441f
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Aug 21 12:01:05 2020 +0100

    libstdc++: Skip PSTL tests when installed TBB is too old [PR 96718]

    These tests do not actually require TBB, because they only inspect the
    feature test macros present in the headers. However, if TBB is installed
    then its headers will be included, and the version will be checked. If
    the version is too old, compilation fails due to a #error directive.

    This change disables the tests if TBB is not present, so that we skip
    them instead of failing.

    libstdc++-v3/ChangeLog:

            PR libstdc++/96718
            * testsuite/25_algorithms/pstl/feature_test-2.cc: Require
            tbb-backend effective target.
            * testsuite/25_algorithms/pstl/feature_test-3.cc: Likewise.
            * testsuite/25_algorithms/pstl/feature_test-5.cc: Likewise.
            * testsuite/25_algorithms/pstl/feature_test.cc: Likewise.

[Bug libstdc++/96718] 25_algorithms/pstl/feature_test-3.cc has excess error

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96718

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:098a67ff74cca5f17ed630d870adf364c47031f6

commit r10-8652-g098a67ff74cca5f17ed630d870adf364c47031f6
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Aug 21 12:01:05 2020 +0100

    libstdc++: Skip PSTL tests when installed TBB is too old [PR 96718]

    These tests do not actually require TBB, because they only inspect the
    feature test macros present in the headers. However, if TBB is installed
    then its headers will be included, and the version will be checked. If
    the version is too old, compilation fails due to a #error directive.

    This change disables the tests if TBB is not present, so that we skip
    them instead of failing.

    libstdc++-v3/ChangeLog:

            PR libstdc++/96718
            * testsuite/25_algorithms/pstl/feature_test-2.cc: Require
            tbb-backend effective target.
            * testsuite/25_algorithms/pstl/feature_test-3.cc: Likewise.
            * testsuite/25_algorithms/pstl/feature_test-5.cc: Likewise.
            * testsuite/25_algorithms/pstl/feature_test.cc: Likewise.

    (cherry picked from commit 988fb2f597d67cdf3603654372c020c28448441f)

[Bug libstdc++/96718] 25_algorithms/pstl/feature_test-3.cc has excess error

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96718

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
This should be fixed on master and gcc-10 now, please reopen if you still see
it (I didn't change one of the related tests, but I think that one shouldn't be
failing).