public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "crazylht at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/96744] [11 Regression] FAIL: gcc.target/i386/avx512bitalgvl-vpopcntb-1.c execution test Date: Tue, 25 Aug 2020 05:14:12 +0000 [thread overview] Message-ID: <bug-96744-4-0YQ1iqPsJZ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-96744-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96744 --- Comment #7 from Hongtao.liu <crazylht at gmail dot com> --- (In reply to Uroš Bizjak from comment #5) > (In reply to Hongtao.liu from comment #2) > > > Need to add define_insn for movp2qi/movp2hi? > > Yes, this is needed to cover some corner cases. Please see attachment 49114 > [details]. > > However, the patch assumes that avx512vp2intersect implies mavx512dq, Let me check this part. > otherwise there is no direct QImode move from mask register to memory > available. and QImode masks would be indirectly stored through Q_REG. cut from ix86_secondary_reload --- /* QImode spills from non-QI registers require intermediate register on 32bit targets. */ if (mode == QImode && ((!TARGET_64BIT && !in_p && INTEGER_CLASS_P (rclass) && MAYBE_NON_Q_CLASS_P (rclass)) || (!TARGET_AVX512DQ && MAYBE_MASK_CLASS_P (rclass)))) { int regno = true_regnum (x); /* Return Q_REGS if the operand is in memory. */ if (regno == -1) return Q_REGS; return NO_REGS; --- if we disable direct movement between gpr and masks in inline_secondary_memory_needed, how should pass_reload spill QImode mask to memeory, would it be functionality issue? That's why i prefer changing cost model to disable spill to mask in general target, as your patch "Retune mask <-> general moves cost" shows: attachment 49107
next prev parent reply other threads:[~2020-08-25 5:14 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-22 12:28 [Bug target/96744] New: " hjl.tools at gmail dot com 2020-08-23 15:40 ` [Bug target/96744] " cvs-commit at gcc dot gnu.org 2020-08-24 7:47 ` crazylht at gmail dot com 2020-08-24 12:05 ` ubizjak at gmail dot com 2020-08-24 14:08 ` ubizjak at gmail dot com 2020-08-24 14:11 ` ubizjak at gmail dot com 2020-08-24 14:14 ` ubizjak at gmail dot com 2020-08-25 5:14 ` crazylht at gmail dot com [this message] 2020-08-25 11:38 ` rguenth at gcc dot gnu.org 2020-08-27 8:52 ` crazylht at gmail dot com 2020-08-27 9:09 ` crazylht at gmail dot com 2020-08-27 11:09 ` ubizjak at gmail dot com 2020-08-28 7:47 ` cvs-commit at gcc dot gnu.org 2020-08-28 7:53 ` cvs-commit at gcc dot gnu.org 2020-09-15 10:23 ` cvs-commit at gcc dot gnu.org 2020-09-15 10:24 ` crazylht at gmail dot com 2020-10-12 12:28 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-96744-4-0YQ1iqPsJZ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).