public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/96745] [concepts] internal compiler error: in type_memfn_rqual, at cp/typeck.c:10389
Date: Fri, 03 Feb 2023 14:15:47 +0000	[thread overview]
Message-ID: <bug-96745-4-cnzqsC9mZU@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-96745-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96745

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:ed2b519e02eac99fadfa51adc7b11f8854c24575

commit r13-5683-ged2b519e02eac99fadfa51adc7b11f8854c24575
Author: Patrick Palka <ppalka@redhat.com>
Date:   Fri Feb 3 09:15:29 2023 -0500

    c++: ICE on unviable/ambiguous constrained dtors [PR96745]

    Here we're crashing from check_bases_and_members due to
    CLASSTYPE_DESTRUCTOR being an OVERLOAD which, due to the pruning
    performed by add_method, should only happen if there is no viable
    destructor or the destructor is ambiguous because of unsatisfied
    or ambiguous constraints.

    This patch fixes this by making check_bases_and_members naturally handle
    CLASSTYPE_DESTRUCTOR being an OVERLOAD.  It's then convenient to prune
    the OVERLOAD after effectively diagnosing the overload resolution
    failure in check_methods.

            PR c++/96745

    gcc/cp/ChangeLog:

            * class.cc (check_methods): Diagnose an unviable OVERLOAD
            set for CLASSTYPE_DESTRUCTOR differently from an ambiguous one.
            Then prune the OVERLOAD to a single function.
            (check_bases_and_members): Handle CLASSTYPE_DESTRUCTOR being
            an OVERLOAD when calling deduce_noexcept_on_destructor.
            Document why it has to be called before check_methods.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp2a/concepts-dtor1.C: New test.

  parent reply	other threads:[~2023-02-03 14:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-22 12:47 [Bug c++/96745] New: " src at andyf dot de
2020-09-22 19:34 ` [Bug c++/96745] " ppalka at gcc dot gnu.org
2021-01-17 16:52 ` ppalka at gcc dot gnu.org
2021-01-17 16:57 ` ppalka at gcc dot gnu.org
2021-05-05 16:30 ` ppalka at gcc dot gnu.org
2021-09-07 20:43 ` pinskia at gcc dot gnu.org
2023-01-30 20:36 ` ppalka at gcc dot gnu.org
2023-02-03 14:15 ` cvs-commit at gcc dot gnu.org [this message]
2023-02-03 14:21 ` ppalka at gcc dot gnu.org
2023-02-03 14:23 ` ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-96745-4-cnzqsC9mZU@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).